Skip to content

DATAJDBC-1110 #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAJDBC-1110 #1209

wants to merge 1 commit into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Mar 24, 2022

Adressing #1110 issue.
@schauder Please, review this PR

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 24, 2022
@mipo256 mipo256 force-pushed the issue/DATAJDBC-1110 branch from b656bad to 0dbfd12 Compare March 24, 2022 21:32
@mipo256 mipo256 force-pushed the issue/DATAJDBC-1110 branch from 0dbfd12 to 382a423 Compare March 24, 2022 21:36
schauder pushed a commit that referenced this pull request Mar 23, 2023
@mipo256 @schauder
Remove unnecessary parameters after moving of getReference(Identifier…
d893259 
… Processing).

Original pull request #1209
See #1110
schauder added a commit that referenced this pull request Mar 23, 2023
@schauder
Polishing.
e78f7df 
Original pull request #1209
See #1110
@schauder
Copy link
Contributor

Sorry, I rediscovered this PR just after I merged #1458.
But your PR goes beyond that at removes now no longer parameters and fields, so I merged that.

Thanks for your work.

@schauder schauder closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mipo256 @schauder @spring-projects-issues