SqlIdentifier has redundant getReference(IdentifierProcessing) method #1110
Labels
status: pending-design-work
Needs design work before any code can be developed
Milestone
I have noticed that
SqlIdentifier
has redundantSqlIdentifier#getReference(IdentifierProcessing)
method. The thing is, in accordance to the documentation, this method should:But the thing this method does not apply anything in reality and acts in identical manner to
SqlIdentifier#getReference()
. Nither theDefaultSqlIdentifer
, norDerivedSqlIdentifier
do not do basically anything to their underlying sql parameter name (neadless to say aboutCompositeSqlIdentifier
), for example:DerivedSqlIdentifier:
And DefaultSqlIdentifier:
So, in reality, this method does not differ from
SqlIdentifier#getReference()
- it really confuses. Even more - we already haveSqlIdentifier#toSql(IdentifierProcessing)
which it really intended to applyIdentifierProcessing
to theSqlIdentifier
. I assume that this is an architectural miscalculation. Jens @schauder, I think we need to clean this up in order to eliminate confusion.The text was updated successfully, but these errors were encountered: