#57 - Add support for R2DBC subclass exception translation. #97
Conversation
We now use R2DBC's exception hierarchy to translate exceptions into Spring's DataAccessException hierarchy.
| @Nullable | ||
| protected DataAccessException doTranslate(String task, @Nullable String sql, R2dbcException ex) { | ||
|
|
||
| if (ex instanceof R2dbcTransientException) { |
There was a problem hiding this comment.
What are these outer if statements for?
Performance?
Is this worth it?
I find it rather confusing and given that exceptions should be the exception, saving up to two conditionals by paying 1-2 extra doesn't seem worth it.
There was a problem hiding this comment.
This is a branch organization aspect that maintains readability. Transient resources come in one block, non-transients in the other one. See also https://github.com/spring-projects/spring-framework/blob/master/spring-jdbc/src/main/java/org/springframework/jdbc/support/SQLExceptionSubclassTranslator.java.
|
Basically, all conventions originate in how Spring Framework translates exceptions and represents these. We should stick to the Spring JDBC way to remain consistent. |
We now use R2DBC's exception hierarchy to translate exceptions into Spring's DataAccessException hierarchy. Original pull request: #97.
|
Merged |
We now use R2DBC's exception hierarchy to translate exceptions into Spring's
DataAccessExceptionhierarchy.Related ticket: #57.