Skip to content

Add R2DBC-specific exception translation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Feb 5, 2019 · 3 comments
Closed

Add R2DBC-specific exception translation #57

mp911de opened this issue Feb 5, 2019 · 3 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
1.0 M2

Comments

@mp911de
Copy link
Member

mp911de commented Feb 5, 2019

Right now, we're using Spring Framework's JDBC module to apply exception translation. Spring JDBC is heavily based on JDBC API and it makes little sense to pull JDBC API into R2DBC, especially when running in modularized Java 9+ environments.

We should provide our own exception translation mechanism that is built along the lines of Spring JDBC's SQLErrorCodes without using JDBC API.
@mp911de mp911de added the type: enhancement A general enhancement label Feb 5, 2019
@mp911de
Copy link
Member Author

mp911de commented Feb 19, 2019

See SPR-17618 (#22150).

@mp911de
Copy link
Member Author

mp911de commented Mar 25, 2019

R2DBC decided to introduce an exception hierarchy that simplifies exception translation for client libraries. We're going to adopt subclass-based exception translation once that's in place.

See r2dbc/r2dbc-spi#47.

@mp911de mp911de added the status: blocked An issue that's blocked on an external project change label Mar 25, 2019
@mp911de mp911de removed the status: blocked An issue that's blocked on an external project change label Apr 18, 2019
@mp911de mp911de added this to the 1.0 M2 milestone Apr 18, 2019
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
#57 - Prepare issue branch.
7b10314
mp911de added a commit that referenced this issue Apr 18, 2019
@mp911de
#57 - Add support for R2DBC subclass exception translation.
a2a45ad 
We now use R2DBC's exception hierarchy to translate exceptions into Spring's DataAccessException hierarchy.
@mp911de mp911de mentioned this issue Apr 18, 2019
Closed
schauder added a commit that referenced this issue Apr 23, 2019
@schauder
#57 - Added tests for the exception message.
d216064
@schauder schauder assigned mp911de and unassigned schauder Apr 23, 2019
schauder pushed a commit that referenced this issue Apr 24, 2019
@mp911de @schauder
#57 - Add support for R2DBC subclass exception translation.
e161476 
We now use R2DBC's exception hierarchy to translate exceptions into Spring's DataAccessException hierarchy.

Original pull request: #97.
schauder added a commit that referenced this issue Apr 24, 2019
@schauder
#57 - Added tests for the exception message.
f7d3124 
Original pull request: #97.
@schauder
Copy link
Contributor

Done.

schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - introduced alternative bind method.
c3fa187
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - removed call to old bind.
aaeafe0
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - code symmetry.
78d5ceb
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - extracted ParameterbindingPreparedOperation.
5f6ced5
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - minor code improvements.
a5de49a
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - minor code improvements.
da15d80
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - disassembling.
ebf863c
schauder added a commit that referenced this issue Apr 30, 2019
@schauder
#57 - hacking - removed old bind method from interface.
62c9e92
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - changed method name according to review.
0b7ff9d
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - extracted super class.
50978dd
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - separate Bindings class.
10d56ac
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - prepared various single bindings.
df15ae5
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - proper expanded single binding.
977cc53
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - always nice when code compiles.
84c4fbe
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - fixed an error.
0bde3b0
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - fixed another error.
4076699
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - added backup.
4e3a013
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - moved bindings in constructor.
9e61e06
schauder added a commit that referenced this issue May 6, 2019
@schauder
#57 - hacking - ExpandedBindings work as well.
6d0bc57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0 M2
Development

No branches or pull requests
2 participants
@schauder @mp911de