Skip to content

Align OffsetScrolling to zero-based indexes #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Align OffsetScrolling to zero-based indexes #2891

wants to merge 2 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Apr 10, 2024

OffsetScrollPosition is now 0-based instead of 1-based. We differentiate between ScrollPosition.offset() as initial position and ScrollPosition.offset(0) pointing to the first returned element.

Closes #2890

mp911de added 2 commits April 10, 2024 09:28
OffsetScrollPosition is now 0-based instead of 1-based. We differentiate between ScrollPosition.offset() as initial position and ScrollPosition.offset(0) pointing to the first returned element.

Closes #2890
@mp911de mp911de requested a review from meistermeier April 10, 2024 07:45
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 10, 2024
@mp911de mp911de changed the title Adopt to changes in Spring Data Commons Align OffsetScrolling to zero-based indexes Apr 10, 2024
mp911de added a commit that referenced this pull request Apr 10, 2024
OffsetScrollPosition is now 0-based instead of 1-based. We differentiate between ScrollPosition.offset() as initial position and ScrollPosition.offset(0) pointing to the first returned element.

Remove unused variable.

Closes #2890
Original pull request: #2891
@mp911de mp911de added this to the 7.3 RC1 (2024.0.0) milestone Apr 10, 2024
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 10, 2024
@mp911de mp911de self-assigned this Apr 10, 2024
@mp911de mp911de closed this Apr 10, 2024
@mp911de mp911de deleted the issue/2890 branch April 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align OffsetScrolling to zero-based indexes
3 participants