Skip to content

Align OffsetScrolling to zero-based indexes #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Apr 10, 2024 · 0 comments
Closed

Align OffsetScrolling to zero-based indexes #2890

mp911de opened this issue Apr 10, 2024 · 0 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
7.3 RC1 (2024.0.0)

Comments

@mp911de
Copy link
Member

mp911de commented Apr 10, 2024

See spring-projects/spring-data-commons#3072
@mp911de mp911de added the type: enhancement A general enhancement label Apr 10, 2024
@mp911de mp911de self-assigned this Apr 10, 2024
mp911de added a commit that referenced this issue Apr 10, 2024
@mp911de
Adopt to changes in Spring Data Commons.
257c9e2 
OffsetScrollPosition is now 0-based instead of 1-based. We differentiate between ScrollPosition.offset() as initial position and ScrollPosition.offset(0) pointing to the first returned element.

Closes #2890
@mp911de mp911de mentioned this issue Apr 10, 2024
Closed
@mp911de mp911de changed the title Align scroll implementation to changes in data-commons Align OffsetScrolling to zero-based indexes Apr 10, 2024
@mp911de mp911de added this to the 7.3 RC1 (2024.0.0) milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
7.3 RC1 (2024.0.0)
Development

Successfully merging a pull request may close this issue.

Align OffsetScrolling to zero-based indexes spring-projects/spring-data-neo4j
1 participant
@mp911de