Skip to content

Provide ReactiveCypherdslConditionExecutor. #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

nk-coding
Copy link
Contributor

Provides a reactive equivalent to CypherdslConditionExecutor.
See #2575

  • You have read the Spring Data Neo4j contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Please note:

  • I did not change the @author tag, as I took existing classes and adopted them. If you want me to change that, please let me know
  • I tried to apply the formatter, however it caused lots of changes which are inconsistent with existing files in the project (as most of my code is just an adoption of existing code). I suspect that my config is broken, therefore, help formatting would be appreciated
  • I set all since to 6.3.3, as mentioned here, the changes will (hopefully) be backported. If you want me to change that, please let me know. I tested my changes also against the 6.3.x branch, so there are hopefully no issues backporting.
  • Even though support for ReactiveQuerydslPredicateExecutor was already implemented with Add support for ReactiveQuerydslPredicateExecutor. #2361, I still mentioned it to the documentation, as I also reference this support in ReactiveCypherdslConditionExecutor

Provides a reactive equivalent to CypherdslConditionExecutor.
See spring-projects#2575
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 2, 2022
@michael-simons michael-simons self-assigned this Aug 3, 2022
@michael-simons michael-simons merged commit 034c6e8 into spring-projects:main Aug 3, 2022
@michael-simons
Copy link
Collaborator

Thanks a ton for that nice contribution, Niklas!

michael-simons pushed a commit that referenced this pull request Aug 3, 2022
@nk-coding
Copy link
Contributor Author

Thanks a lot for accepting it and also for backporting it to 6.3.x

@michael-simons michael-simons mentioned this pull request Jan 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants