Skip to content

Feature request: ReactiveCypherdslConditionExecutor #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nk-coding opened this issue Aug 1, 2022 · 3 comments
Closed

Feature request: ReactiveCypherdslConditionExecutor #2575

nk-coding opened this issue Aug 1, 2022 · 3 comments
Assignees
Labels
type: new-feature A completely new feature

Comments

@nk-coding
Copy link
Contributor

Hi,
in my opinion it would be helpful to have a reactive equivalent to the CypherdslConditionExecutor. I sadly was not able to find one, and to my understanding, I cannot use CypherdslConditionExecutor in a reactive context.
If there is already a way to query for nodes by a Cypher DSL condition (without relying on internal functionality) with reactive repositories, I would be glad to hear about it.
To my understanding, a ReactiveCypherdslConditionExecutor could be implemented by basically taking the non-reactive equivalents, and replacing the return types and the injected Neo4jOperations with their reactive equivalents - at least for my test implementation, this worked well.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 1, 2022
@michael-simons
Copy link
Collaborator

I would happily accept a PR from your branch and polish it up. That's great stuff.

@michael-simons michael-simons self-assigned this Aug 2, 2022
@nk-coding
Copy link
Contributor Author

I'm happy to provide a PR, just one question, should I provide one for main, or 6.3.x?

@michael-simons
Copy link
Collaborator

So, it's a new feature and technically it shouldn't appear in a patch, so the answer is main. Also, you can use Java 17 there.

However, as it will be sometime until the next major release, I'm happy to backport it to 6.3.

nk-coding added a commit to nk-coding/spring-data-neo4j that referenced this issue Aug 2, 2022
Provides a reactive equivalent to CypherdslConditionExecutor.
See spring-projects#2575
@michael-simons michael-simons added type: new-feature A completely new feature and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 3, 2022
michael-simons pushed a commit that referenced this issue Aug 3, 2022
@michael-simons michael-simons mentioned this issue Jan 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new-feature A completely new feature
Projects
None yet
Development

No branches or pull requests

3 participants