-
Notifications
You must be signed in to change notification settings - Fork 1.1k
DATAMONGO-2059 - Favor collection.countDocuments() over collection.count() which will be removed. #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…collection.countDocuments() This commit switches from simple collection.count(), operating on potentially false collection statistic, to countDocuments() using an aggregation for accurate results. The transition required query modifications at some points because $match does not support $near and $nearSphere but require $geoWithin along with $center or $centerSphere which does not support $minDistance (see https://jira.mongodb.org/browse/SERVER-37043). $geoWithin further more does not sort results by distance, but this fact can be ignored when just counting matches. Examples: { location : { $near : [-73.99171, 40.738868], $maxDistance : 1.1 } } { location : { $geoWithin : { $center: [ [-73.99171, 40.738868], 1.1] } } } { location : { $near : [-73.99171, 40.738868], $minDistance : 0.1, $maxDistance : 1.1 } } {$and :[ { $nor :[ { location :{ $geoWithin :{ $center :[ [-73.99171, 40.738868 ], 0.01] } } } ]}, { location :{ $geoWithin :{ $center :[ [-73.99171, 40.738868 ], 1.1] } } } ] }
5cac65f
to
4d1e27a
Compare
Move query rewriting into CountQuery. Consider existing $and items during query rewrite.
mp911de
pushed a commit
that referenced
this pull request
Oct 25, 2019
…collection.countDocuments(). This commit switches from simple collection.count(), operating on potentially false collection statistic, to countDocuments() using an aggregation for accurate results. The transition required query modifications at some points because $match does not support $near and $nearSphere but require $geoWithin along with $center or $centerSphere which does not support $minDistance (see https://jira.mongodb.org/browse/SERVER-37043). $geoWithin further more does not sort results by distance, but this fact can be ignored when just counting matches. Examples: { location : { $near : [-73.99171, 40.738868], $maxDistance : 1.1 } } { location : { $geoWithin : { $center: [ [-73.99171, 40.738868], 1.1] } } } { location : { $near : [-73.99171, 40.738868], $minDistance : 0.1, $maxDistance : 1.1 } } {$and :[ { $nor :[ { location :{ $geoWithin :{ $center :[ [-73.99171, 40.738868 ], 0.01] } } } ]}, { location :{ $geoWithin :{ $center :[ [-73.99171, 40.738868 ], 1.1] } } } ] } Original pull request: #604.
mp911de
added a commit
that referenced
this pull request
Oct 25, 2019
Move query rewriting into CountQuery. Consider existing $and items during query rewrite. Original pull request: #604.
That's merged and polished now. |
mp911de
added a commit
that referenced
this pull request
Oct 25, 2019
Move query rewriting into CountQuery. Consider existing $and items during query rewrite. Original pull request: #604.
Can we get this one merged into 2.2.X? It doesn't seem THAT major and we're in a huge need for this, Mongo is totally crapping out on us when using "count" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches from simple
collection.count()
, operating on potentially false collection statistic, tocountDocuments()
using an aggregation for accurate results.The transition required query modifications at some points because
$match
does not support$near
nor$nearSphere
but requires$geoWithin
using$center
or$centerSphere
which does not support$minDistance
(see SERVER-37043).$geoWithin
further more does not sort results by distance, but this fact can be ignored when just counting matches.ℹ️ The change is a requirement for upgrading to the next driver version that no longer supports
collection.count()
.Examples: