Check MongoException error labels for recoverable transaction errors [DATAMONGO-2073]

[spring-projects-issues]

Christoph Strobl opened DATAMONGO-2073 and commented

Check MongoException for lables TransientTransactionError, UnknownTransactionCommitResult indicating potentially recoverable transaction commit errors and translate them to TransientDataAccessException.

See MongoException#hasErrorLabel(String).

---

Issue Links:

• DATAMONGO-2075 Open up MongoTransaction manager to allow transaction commit retry.

• DATAMONGO-2291 MongoExceptionTranslator hides WriteConflicts

Referenced from: pull request #605

1 votes, 2 watchers

[spring-projects-issues]

Christoph Strobl commented

Moved to backlog in favor of DATAMONGO-2075

[spring-projects-issues]

Mark Baker-Munton commented

DATAMONGO-2075 doesn't solve the problem entirely as some transaction errors can be thrown prior to a transaction commit operation.

WriteConflicts are one example:

1. begin tx
2. update document y
3. commit tx 

If another thread/user modifies document y after beginning the transaction and before updating the document, an exception will be thrown on line 2 and not line 3

[WitekBaranowskiAllegro]

@christophstrobl do you have any plans to fix this issue?

[mp911de]

We do not have means to represent the dimension of contextual transient exceptions. If we would wrap certain exceptions into a TransientException wrapper, then calling code would not be able to handle the actual exception type. Also, conditionally using a different exception type would introduce a different behavior potentially breaking existing application code.

As there is no other means of adding the information, we suggest using MongoExceptionTranslator.isTransientFailure.