DATAMONGO-978 - Derived delete query should pass on type information. #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
We now pass on type information for derived delete queries to the according delete operation. This propagates the information correctly to the according Before and After events. Before this change the type would have been set to null in case of non collection like method return type.
christophstrobl
added a commit
that referenced
this pull request
Jul 3, 2014
We now pass on type information for derived delete queries to the according delete operation. This propagates the information correctly to the according Before and After events. Before this change the type would have been set to null in case of non collection like method return type. Original pull request: #199.
|
LGTM, cherry-picked with a typo fixed (Abstrac[t]...) via 998bb09. |
christophstrobl
added a commit
that referenced
this pull request
Jul 3, 2014
We now pass on type information for derived delete queries to the according delete operation. This propagates the information correctly to the according Before and After events. Before this change the type would have been set to null in case of non collection like method return type. Original pull request: #199.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass on type information for derived delete queries to the according delete operation. This propagates the information correctly to the Before and After events.
Before this change the type would have been set to
nullin case of non collection like method return type.Should be back ported to
1.5.x.