deleteBy/removeBy repository methods don't set type information in Before/AfterDeleteEvent [DATAMONGO-978]

[spring-projects-issues]

Faisal Feroz opened DATAMONGO-978 and commented

In AbstractMongoQuery.java the nested DeleteExecution class has the following method

private Object deleteAndConvertResult(Query query, MongoEntityMetadata<?> metadata) {

			if (method.isCollectionQuery()) {
				return operations.findAllAndRemove(query, metadata.getJavaType());
			}

			WriteResult writeResult = operations.remove(query, metadata.getCollectionName());
			return writeResult != null ? writeResult.getN() : 0L;
		}

Here the javatype is not passed to operations.remove method although there is an overloaded method of remove which accepts the type. The result ends up as having null in the type value inside the Before/AfterDeleteEvent and the result events are although fired but never end up handled in the respective Type's Event Handlers if any.

A simple fix would be to change it to:

WriteResult writeResult = operations.remove(query, metadata.getJavaType(), metadata.getCollectionName());

---

Affects: 1.5 GA (Dijkstra)

Referenced from: pull request #199

Backported to: 1.5.2 (Dijkstra SR2)

[spring-projects-issues]

Faisal Feroz commented

this issue is related to the functionality provided under DATAMONGO-566

[spring-projects-issues]

Christoph Strobl commented

Sorry for the inconvenience and thanks for the detailed report!

[spring-projects-issues]

Thomas Darimont commented

Merged into master and back-ported in 1.5.x branch for Dijkstra SR2