Improve string query parsing flow. #3321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jan 19, 2024
| * @since 3.2.3 | ||
| * @author Christoph Strobl | ||
| */ | ||
| static class CachableQuery { |
There was a problem hiding this comment.
The caching key is already quite complex. I'd suggest to keep only the isUnsorted code path and refine the way we render queries with a sort. That is, render everything before and after ORDER BY in a first pass (e.g. held in a QueryEnhancer instance). Then, render Sort with rather simple string concatenation.
There was a problem hiding this comment.
The above is deliberately targeting the 3.2.x line without applying major changes.
There was a problem hiding this comment.
Created #3326 to follow up on splitting the transformation (targeting main development line)
This commit makes sure to avoid unnecessary parsing of queries when sorting must not be appended. Additionally the parsed result is cached on a per query string with sort expression basis to avoid parsing repeating occurrences of the same expressions eg. while paging through results.
christophstrobl
force-pushed
the
issue/3.2.x/3310
branch
from
3ab9e29 to
8bb28a3
Compare
mp911de
pushed a commit
that referenced
this pull request
Feb 14, 2024
This commit makes sure to avoid unnecessary parsing of queries when sorting must not be appended. Additionally the parsed result is cached on a per query string with sort expression basis to avoid parsing repeating occurrences of the same expressions eg. while paging through results. Closes: #3310 Original pull request: #3321
mp911de
pushed a commit
that referenced
this pull request
Feb 14, 2024
This commit makes sure to avoid unnecessary parsing of queries when sorting must not be appended. Additionally the parsed result is cached on a per query string with sort expression basis to avoid parsing repeating occurrences of the same expressions eg. while paging through results. Closes: #3310 Original pull request: #3321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3310, #3311