Skip to content

Avoid string query parsing when sorting must not be applied #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Jan 10, 2024 · 0 comments
Closed

Avoid string query parsing when sorting must not be applied #3310

christophstrobl opened this issue Jan 10, 2024 · 0 comments
Assignees
@christophstrobl
Labels
type: task A general task
Milestone
3.2.3 (2023.1.3)

Comments

@christophstrobl
Copy link
Member

No description provided.

@christophstrobl christophstrobl added the type: task A general task label Jan 10, 2024
@christophstrobl christophstrobl self-assigned this Jan 10, 2024
@christophstrobl christophstrobl mentioned this issue Jan 10, 2024
Closed
@christophstrobl christophstrobl mentioned this issue Jan 18, 2024
Closed
mp911de added a commit that referenced this issue Feb 14, 2024
@mp911de
Polishing.
e511f7f 
Avoid unconditional ConcurrentLruCache instances for each String-based query.

See: #3310
Original pull request: #3321
mp911de pushed a commit that referenced this issue Feb 14, 2024
@christophstrobl @mp911de
Avoid repeated query parsing.
f66e185 
This commit makes sure to avoid unnecessary parsing of queries when sorting must not be appended.
Additionally the parsed result is cached on a per query string with sort expression basis to avoid parsing repeating occurrences of the same expressions eg. while paging through results.

Closes: #3310
Original pull request: #3321
mp911de added a commit that referenced this issue Feb 14, 2024
@mp911de
Polishing.
4dda7f3 
Avoid unconditional ConcurrentLruCache instances for each String-based query.

See: #3310
Original pull request: #3321
@mp911de mp911de linked a pull request Feb 14, 2024 that will close this issue
Improve string query parsing flow. #3321
Closed
@mp911de mp911de added this to the 3.2.3 (2023.1.3) milestone Feb 14, 2024
mp911de added a commit that referenced this issue Feb 14, 2024
@mp911de
Polishing.
fbe9b12 
Avoid unconditional ConcurrentLruCache instances for each String-based query.

See: #3310
Original pull request: #3321
mp911de added a commit that referenced this issue Feb 14, 2024
@mp911de
Polishing.
ff92e85 
Avoid unconditional ConcurrentLruCache instances for each String-based query.

See: #3310
Original pull request: #3321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: task A general task
Projects
None yet
Milestone
3.2.3 (2023.1.3)
Development

Successfully merging a pull request may close this issue.

Improve string query parsing flow. spring-projects/spring-data-jpa
2 participants
@mp911de @christophstrobl