Skip to content

Suggested patch to #2540 #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Suggested patch to #2540 #2542

wants to merge 2 commits into from

Conversation

cigaly
Copy link
Contributor

@cigaly cigaly commented May 23, 2022

Main branch change to issue described in HibernateJpaParametersParameterAccessor constructor may throw IllegalStateException #2540

Similar change (only difference is jakarta vs javax)should be applied to branch 2.7.x

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 23, 2022
@schauder
Copy link
Contributor

Thanks @cigaly for the PR. Could you share your full name, so we can reference you with an @author tag in the source?

@schauder schauder added type: bug A general bug status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels May 24, 2022
@schauder schauder self-assigned this May 24, 2022
@cigaly
Copy link
Contributor Author

cigaly commented May 24, 2022

Thanks @cigaly for the PR. Could you share your full name, so we can reference you with an @author tag in the source?

Sorry, I've considered that as minor change so did not added author tag. Full name is Cedomir Igaly

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 24, 2022
schauder pushed a commit that referenced this pull request May 25, 2022
@cigaly @schauder
Improve robustness of HibernateJpaParametersParameterAccessor.
d31a03c 
This change avoids errors when no transactional EntityManager is available.

Closes #2540
Original pull request #2542
schauder added a commit that referenced this pull request May 25, 2022
@schauder
Polishing.
bb91dea 
Added author tag, JavaDoc and improved test name.

See #2540
Original pull request #2542
schauder pushed a commit that referenced this pull request May 25, 2022
@cigaly @schauder
Improve robustness of HibernateJpaParametersParameterAccessor.
718f920 
This change avoids errors when no transactional EntityManager is available.

Closes #2540
Original pull request #2542
schauder added a commit that referenced this pull request May 25, 2022
@schauder
Polishing.
4aeac55 
Added author tag, JavaDoc and improved test name.

See #2540
Original pull request #2542
@schauder
Copy link
Contributor

Thanks, that's merged and back ported.

@schauder schauder closed this May 25, 2022
@schauder schauder mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schauder schauder

Labels
status: feedback-provided Feedback has been provided type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cigaly @schauder @spring-projects-issues