Skip to content

Commit 4aeac55

Browse files
committed
Polishing.
Added author tag, JavaDoc and improved test name. See #2540 Original pull request #2542
1 parent 718f920 commit 4aeac55

File tree

2 files changed

+21
-13
lines changed

2 files changed

+21
-13
lines changed

spring-data-jpa/src/main/java/org/springframework/data/jpa/provider/HibernateJpaParametersParameterAccessor.java

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
*
3333
* @author Wonchul Heo
3434
* @author Jens Schauder
35+
* @author Cedomir Igaly
3536
* @since 2.7
3637
*/
3738
class HibernateJpaParametersParameterAccessor extends JpaParametersParameterAccessor {

spring-data-jpa/src/test/java/org/springframework/data/jpa/provider/HibernateJpaParametersParameterAccessorUnitTests.java

+20-13
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
package org.springframework.data.jpa.provider;
22

33
import jakarta.persistence.EntityManager;
4+
5+
import java.lang.reflect.Method;
6+
47
import org.junit.jupiter.api.Assertions;
58
import org.junit.jupiter.api.Test;
69
import org.junit.jupiter.api.extension.ExtendWith;
@@ -12,37 +15,41 @@
1215
import org.springframework.transaction.TransactionStatus;
1316
import org.springframework.transaction.support.DefaultTransactionDefinition;
1417

15-
import java.lang.reflect.Method;
16-
18+
/**
19+
* Unit tests for {@link HibernateJpaParametersParameterAccessor}.
20+
*
21+
* @author Cedomir Igaly
22+
*/
1723
@ExtendWith(SpringExtension.class)
1824
@ContextConfiguration("classpath:hjppa-test.xml")
1925
public class HibernateJpaParametersParameterAccessorUnitTests {
2026

21-
@Autowired
22-
private EntityManager em;
27+
@Autowired private EntityManager em;
2328

24-
@Autowired
25-
private PlatformTransactionManager transactionManager;
29+
@Autowired private PlatformTransactionManager transactionManager;
2630

2731
@Test
2832
void withoutTransaction() throws NoSuchMethodException {
29-
simpleTest();
33+
parametersCanGetAccessesOutsideTransaction();
3034
}
3135

3236
@Test
3337
void withinTransaction() throws Exception {
34-
final TransactionStatus tx = transactionManager.getTransaction(new DefaultTransactionDefinition());
38+
39+
TransactionStatus tx = transactionManager.getTransaction(new DefaultTransactionDefinition());
3540
try {
36-
simpleTest();
41+
parametersCanGetAccessesOutsideTransaction();
3742
} finally {
3843
transactionManager.rollback(tx);
3944
}
4045
}
4146

42-
private void simpleTest() throws NoSuchMethodException {
43-
final Method method = EntityManager.class.getMethod("flush");
44-
final JpaParameters parameters = new JpaParameters(method);
45-
final HibernateJpaParametersParameterAccessor accessor = new HibernateJpaParametersParameterAccessor(parameters, new Object[]{}, em);
47+
private void parametersCanGetAccessesOutsideTransaction() throws NoSuchMethodException {
48+
49+
Method method = EntityManager.class.getMethod("flush");
50+
JpaParameters parameters = new JpaParameters(method);
51+
HibernateJpaParametersParameterAccessor accessor = new HibernateJpaParametersParameterAccessor(parameters,
52+
new Object[] {}, em);
4653
Assertions.assertEquals(0, accessor.getValues().length);
4754
Assertions.assertEquals(parameters, accessor.getParameters());
4855
}

0 commit comments

Comments
 (0)