DATAJPA-1261 - Revert DATAJPA-931. #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the functional change made by DATAJPA-931. This means merge will be called again, even if the entity for which save was called is already attached to the session. Tests stay in place to verify the new old behavior.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 5, 2018
…lementation of CrudRepository.save(…). This reverts the functional change made by DATAJPA-931. This means merge will be called again, even if the entity for which save was called is already attached to the session. Tests stay in place to verify the new old behavior. Related ticket: DATAJPA-931. Original pull request: #249.
odrotbohm
pushed a commit
that referenced
this pull request
Feb 5, 2018
…lementation of CrudRepository.save(…). This reverts the functional change made by DATAJPA-931. This means merge will be called again, even if the entity for which save was called is already attached to the session. Tests stay in place to verify the new old behavior. Related ticket: DATAJPA-931. Original pull request: #249.
|
Could anyone explain in brief why this change was reverted in 2.0.X? Any ticket? |
|
The original ticket can be found here: But I agree that it was not stated why it was reverted. |
|
Thanks, I'll ask this question there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the functional change made by DATAJPA-931.
This means merge will be called again, even if the entity for which save was called is already attached to the session.
Tests stay in place to verify the new old behavior.