Optimize calls to SimpleJpaRepository.save(…) if the entity is still attached [DATAJPA-931]

[spring-projects-issues]

Oliver Drotbohm opened DATAJPA-931 and commented

As described in Vlad Mihalcea's blog, the call to merge for an entity still attached to a persistence context can lead to superflous code execution and event triggering in persistence providers.

We should guard the call to EntityManager.merge(…) with a check whether the given entity is currently attached

---

Reference URL: https://vladmihalcea.com/2016/07/19/jpa-persist-and-merge/

Issue Links:

• DATAJPA-1261 Revert optimizations made for existing entities in implementation of CrudRepository.save(…)

Referenced from: pull request #237, and commits a2d3acf, 68fcf6e, 8265daf, 476baa4, f3b9131, c47ff56, 26f70bf

Backported to: 2.0.3 (Kay SR3)

[spring-projects-issues]

Сергей Цыпанов commented

There's a pull request #249 reverting changes made in #237. Is there any explanation why those changes were reverted?

[spring-projects-issues]

Oliver Drotbohm commented

See my comments on DATAJPA-1261 for further details

[spring-projects-issues]

Сергей Цыпанов commented

Thanks for explanation!