Skip to content

Upgrade to Hibernate 6.2.0 #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eng-Fouad opened this issue Apr 5, 2023 · 5 comments
Closed

Upgrade to Hibernate 6.2.0 #2899

Eng-Fouad opened this issue Apr 5, 2023 · 5 comments
Labels
status: blocked An issue that's blocked on an external project change type: dependency-upgrade A dependency upgrade

Comments

@Eng-Fouad
Copy link
Contributor

cc @odrotbohm
@Eng-Fouad Eng-Fouad mentioned this issue Apr 5, 2023
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 5, 2023
@Eng-Fouad Eng-Fouad mentioned this issue Apr 5, 2023
Closed
@odrotbohm
Copy link
Member

Thanks for the contribution. Note that dependency updates are usually something we have to do ourselves, as we have to coordinate with the downstream portfolio regarding their plans to upgrade, too.

For reference for others: also note that you can already use Hibernate 6.2 with an existing boot application by simply configuring hibernate.version to 6.2.0.Final. What's suggested here is upgrading Spring Data's build to Hibernate 6.2, which, given we primarily target JPA in our production code, is more of a testing topic than a "can Spring Data JPA work with Hibernate 6.2".

@odrotbohm odrotbohm added the type: dependency-upgrade A dependency upgrade label Apr 5, 2023
@Eng-Fouad
Copy link
Contributor Author

@odrotbohm I think this issue needs to be tagged with milestone (3.1 RC1 (2023.0.0)), right?

@odrotbohm
Copy link
Member

We're not done yet. There are a couple of tests failing after the upgrade. Investigating.

@odrotbohm odrotbohm reopened this Apr 5, 2023
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Removing all references to removed PostgresSQL91Dialect.
2db0f50 
References #2899, #2901.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Switch order of persistence provider dependencies.
7345ba1 
Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Polishing.
5b5470c 
Avoid Hibernate debug logging to leak out of MetaAnnotatedQueryMethodHibernateIntegrationTests.

Related ticket #2899.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Fix naming of integration tests to make sure we can run the ones for …
8cf8d22 
…Hibernate and Eclipselink independently.

Ticket: #2899.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Fix naming of integration tests to make sure we can run the ones for …
f7152d1 
…Hibernate and Eclipselink independently.

Ticket: #2899.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Fix naming of integration tests to make sure we can run the ones for …
9293c91 
…Hibernate and Eclipselink independently.

Ticket: #2899.
odrotbohm added a commit that referenced this issue Apr 5, 2023
@odrotbohm
Polishing.
3721097 
Avoid Hibernate debug logging to leak out of MetaAnnotatedQueryMethodHibernateIntegrationTests.

Related ticket #2899.
odrotbohm pushed a commit that referenced this issue Apr 5, 2023
@Eng-Fouad @odrotbohm
Upgrade to Hibernate 6.2.
b44816c 
Upgrade Postgres to 10 for stored procedure related tests. Move off deprecated Hibernate Postgres 9.1 dialect.

Switch order of persistence provider dependencies. Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
odrotbohm added a commit that referenced this issue Apr 6, 2023
@odrotbohm
Less extensive test on proxy identifier access.
78795c6 
The upgrade to Hibernate 6.2 causes its proxy generation strategy to differ depending on execution context. We previously used a lazy many-to-one relationship to verify our proxy identifier logic as that relationship reliably resulted in a proxy instance being created on versions < 6.2. It looks like some optimizations in Hibernate [0] now cause it "optimize" the proxy away. I wasn't able to figure out the exact circumstances of that optimization but our tests running on CI reliably didn't see a proxy returned while local, standalone executions did.

We now simply obtain a proxy through EntityManager.getReference(…) and verify that the identifier is still accessible, dropping the addition check for a non-initialization.

[0] https://hibernate.atlassian.net/browse/HHH-15790

Related ticket: #2899.
@odrotbohm
Copy link
Member

This is blocked as we cannot get the test case checking that our identifier access code does not initialize Hibernate proxies to run reliably. It works locally, it doesn't on CI. It looks like Hibernate under some circumstances optimizes the proxies away (likely nice for users) but we unfortunately reliably need to get one to perform the test. I've reached out to the Hibernate team for advice.

@odrotbohm odrotbohm added status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 6, 2023
odrotbohm pushed a commit that referenced this issue Apr 11, 2023
@Eng-Fouad @odrotbohm
Upgrade to Hibernate 6.2.
56a9d48 
Upgrade Postgres to 10 for stored procedure related tests. Move off deprecated Hibernate Postgres 9.1 dialect.

Switch order of persistence provider dependencies. Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
@odrotbohm odrotbohm mentioned this issue Apr 12, 2023
Closed
2 tasks
odrotbohm added a commit that referenced this issue Apr 12, 2023
@odrotbohm
Temporarily disable stored procedure tests for Postgres.
bf86c57 
On Hibernate 6.2 these tests run into class loading problems on CI (likely related to [0]). Cleanup is tracked in #2911.

Related ticket: #2899.

[0 https://hibernate.atlassian.net/browse/HHH-15790]
odrotbohm pushed a commit that referenced this issue Apr 12, 2023
@Eng-Fouad @odrotbohm
Upgrade to Hibernate 6.2.
efd799c 
Upgrade Postgres to 10 for stored procedure related tests. Move off deprecated Hibernate Postgres 9.1 dialect.

Switch order of persistence provider dependencies. Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
odrotbohm added a commit that referenced this issue Apr 12, 2023
@odrotbohm
Avoid strong proxy checks in test case for identifier access.
c370425 
Under still to clarify circumstances a class processed by Hibernate might result in proxies *not* created for a otherwise proxied relationship. So far, our tests have relied on those cases always return a proxy reliably but some optimizations in Hibernate 6.2 (likely [0]) don't allow creating proxies reliably.

Until we find a better way to reliably create a proxy we back off from strictly checking whether we deal with a proxy.

Related tickets: #2899.

[0] https://hibernate.atlassian.net/browse/HHH-15790
odrotbohm added a commit that referenced this issue Apr 12, 2023
@odrotbohm
Temporarily disable stored procedure tests for Postgres.
7729747 
On Hibernate 6.2 these tests run into class loading problems on CI (likely related to [0]). Cleanup is tracked in #2911.

Related ticket: #2899.

[0 https://hibernate.atlassian.net/browse/HHH-15790]
gregturn pushed a commit that referenced this issue Apr 26, 2023
@Eng-Fouad @gregturn
Upgrade to Hibernate 6.2.
b18cd62 
Move off deprecated Hibernate Postgres 9.1 dialect.

Switch order of persistence provider dependencies. Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
gregturn pushed a commit that referenced this issue Apr 26, 2023
@Eng-Fouad @gregturn
Backport support for Hibernate 6.2.
1d3c8a2 
Move off deprecated Hibernate Postgres 9.1 dialect.

Switch order of persistence provider dependencies. Hibernate 6.2 needs to be declared before Eclipselink as the latter pulls in JPA 3.0 but the former now strongly requires 3.1.

Related tickets: #2899.
gregturn pushed a commit that referenced this issue Apr 27, 2023
@odrotbohm @gregturn
Avoid strong proxy checks in test case for identifier access.
6d22a29 
Under still to clarify circumstances a class processed by Hibernate might result in proxies *not* created for a otherwise proxied relationship. So far, our tests have relied on those cases always return a proxy reliably but some optimizations in Hibernate 6.2 (likely [0]) don't allow creating proxies reliably.

Until we find a better way to reliably create a proxy we back off from strictly checking whether we deal with a proxy.

Related tickets: #2899.

[0] https://hibernate.atlassian.net/browse/HHH-15790
gregturn pushed a commit that referenced this issue Apr 28, 2023
@odrotbohm @gregturn
Avoid strong proxy checks in test case for identifier access.
d9e736a 
Under still to clarify circumstances a class processed by Hibernate might result in proxies *not* created for a otherwise proxied relationship. So far, our tests have relied on those cases always return a proxy reliably but some optimizations in Hibernate 6.2 (likely [0]) don't allow creating proxies reliably.

Until we find a better way to reliably create a proxy we back off from strictly checking whether we deal with a proxy.

Related tickets: #2899.

[0] https://hibernate.atlassian.net/browse/HHH-15790
gregturn pushed a commit that referenced this issue Apr 28, 2023
@odrotbohm @gregturn
Avoid strong proxy checks in test case for identifier access.
7ba07ea 
Under still to clarify circumstances a class processed by Hibernate might result in proxies *not* created for a otherwise proxied relationship. So far, our tests have relied on those cases always return a proxy reliably but some optimizations in Hibernate 6.2 (likely [0]) don't allow creating proxies reliably.

Until we find a better way to reliably create a proxy we back off from strictly checking whether we deal with a proxy.

Related tickets: #2899.

[0] https://hibernate.atlassian.net/browse/HHH-15790
gregturn pushed a commit that referenced this issue Apr 28, 2023
@odrotbohm @gregturn
Avoid strong proxy checks in test case for identifier access.
13bb22c 
Under still to clarify circumstances a class processed by Hibernate might result in proxies *not* created for a otherwise proxied relationship. So far, our tests have relied on those cases always return a proxy reliably but some optimizations in Hibernate 6.2 (likely [0]) don't allow creating proxies reliably.

Until we find a better way to reliably create a proxy we back off from strictly checking whether we deal with a proxy.

Related tickets: #2899.

[0] https://hibernate.atlassian.net/browse/HHH-15790
@gregturn
Copy link
Contributor

gregturn commented May 4, 2023

Resolved via #2917.

@gregturn gregturn closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: blocked An issue that's blocked on an external project change type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Hibernate version to 6.2.0.Final Eng-Fouad/spring-data-jpa
4 participants
@odrotbohm @gregturn @Eng-Fouad @spring-projects-issues