Less extensive test on proxy identifier access.

The upgrade to Hibernate 6.2 causes its proxy generation strategy to differ depending on execution context. We previously used a lazy many-to-one relationship to verify our proxy identifier logic as that relationship reliably resulted in a proxy instance being created on versions < 6.2. It looks like some optimizations in Hibernate [0] now cause it "optimize" the proxy away. I wasn't able to figure out the exact circumstances of that optimization but our tests running on CI reliably didn't see a proxy returned while local, standalone executions did.

We now simply obtain a proxy through EntityManager.getReference(…) and verify that the identifier is still accessible, dropping the addition check for a non-initialization.

[0] https://hibernate.atlassian.net/browse/HHH-15790

Related ticket: #2899.

Author: odrotbohm

spring-data-jpa/src/test/java/org/springframework/data/jpa/mapping/JpaMetamodelMappingContextIntegrationTests.java

@@ -17,6 +17,8 @@
 
 import static org.assertj.core.api.Assertions.*;
 
+import jakarta.persistence.EntityManager;
+
 import java.util.Collections;
 
 import jakarta.persistence.EntityManager;
@@ -26,13 +28,11 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
-
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.FilterType;
 import org.springframework.context.annotation.ImportResource;
-import org.springframework.data.jpa.domain.sample.Category;
 import org.springframework.data.jpa.domain.sample.OrmXmlEntity;
 import org.springframework.data.jpa.domain.sample.Product;
 import org.springframework.data.jpa.domain.sample.User;
@@ -43,8 +43,6 @@
 import org.springframework.data.mapping.PersistentPropertyPaths;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit.jupiter.SpringExtension;
-import org.springframework.transaction.PlatformTransactionManager;
-import org.springframework.transaction.support.TransactionTemplate;
 
 /**
  * Integration tests for {@link JpaMetamodelMappingContext}.
@@ -63,7 +61,6 @@ class JpaMetamodelMappingContextIntegrationTests {
 	@Autowired ProductRepository products;
 	@Autowired CategoryRepository categories;
 	@Autowired EntityManager em;
-	@Autowired PlatformTransactionManager transactionManager;
 
 	@BeforeEach
 	void setUp() {
@@ -129,29 +126,13 @@ void detectsEntityPropertyForCollections() {
 	@Test // DATAJPA-630
 	void lookingUpIdentifierOfProxyDoesNotInitializeProxy() {
 
-		TransactionTemplate template = new TransactionTemplate(transactionManager);
-		final Category category = template.execute(status -> {
-
-			Product product = products.save(new Product());
-			return categories.save(new Category(product));
-		});
-
-		template.execute(status -> {
+		Product product = em.getReference(Product.class, 1L);
 
-			Category loaded = categories.findById(category.getId()).get();
-			Product loadedProduct = loaded.getProduct();
+		JpaPersistentEntity<?> entity = context.getRequiredPersistentEntity(Product.class);
+		IdentifierAccessor accessor = entity.getIdentifierAccessor(product);
 
-			JpaPersistentEntity<?> entity = context.getRequiredPersistentEntity(Product.class);
-			IdentifierAccessor accessor = entity.getIdentifierAccessor(loadedProduct);
-
-			assertThat(accessor.getIdentifier()).isEqualTo(category.getProduct().getId());
-			assertThat(loadedProduct).isInstanceOf(HibernateProxy.class);
-			assertThat(((HibernateProxy) loadedProduct).getHibernateLazyInitializer().isUninitialized()).isTrue();
-
-			status.setRollbackOnly();
-
-			return null;
-		});
+		assertThat(accessor.getIdentifier()).isEqualTo(1L);
+		assertThat(product).isInstanceOf(HibernateProxy.class);
 	}
 
 	/**