Skip to content

Overload multiSearch method to support list of IndexCoordinates #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AIRahimi
Copy link
Contributor

Pretty much copy/paste with the exception of one more list (IndexCoordinates) that is iterated along with the classes and added per query.

Could've (maybe should've) refactored existing methods to avoid duplicate fragments, but did not want to change existing code too much since this is my first contribution.

Closes #2434

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2023
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jan 26, 2023
@sothawo sothawo merged commit b0c2ce3 into spring-projects:main Jan 26, 2023
@sothawo
Copy link
Collaborator

sothawo commented Jan 26, 2023

Thanks a lot for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for separate IndexCoordinates per query in multiSearch.
3 participants