Skip to content

Add support for separate IndexCoordinates per query in multiSearch. #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AIRahimi opened this issue Jan 25, 2023 · 3 comments · Fixed by #2436
Closed

Add support for separate IndexCoordinates per query in multiSearch. #2434

AIRahimi opened this issue Jan 25, 2023 · 3 comments · Fixed by #2436
Labels
type: enhancement A general enhancement
Milestone
5.1 M1 (2023.0.0)

Comments

@AIRahimi
Copy link
Contributor

The API

multiSearch(List<? extends Query> queries, List<Class<?>> classes, IndexCoordinates index)

takes an IndexCoordinates and sends in with each query in the multiSearch. ElasticSearch supports different indexes per query in the multisearch so we should be able to send in a list of IndexCoordinates that is iterated along with the query and class.
@AIRahimi AIRahimi changed the title Add support for separate IndexCoordinates query in multiSearch. Add support for separate IndexCoordinates per query in multiSearch. Jan 25, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2023
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 25, 2023
@AIRahimi
Copy link
Contributor Author

@sothawo Can I solve this one my self? :)

@sothawo
Copy link
Collaborator

sothawo commented Jan 25, 2023

Feel free to create a pull request with the changes

@AIRahimi AIRahimi mentioned this issue Jan 25, 2023
Merged
@AIRahimi
Copy link
Contributor Author

Done.

sothawo pushed a commit that referenced this issue Jan 26, 2023
@AIRahimi
Overload multiSearch method to support list of IndexCoordinates.
b0c2ce3 
Original Pull Request #2436
Closes #2434
@sothawo sothawo added this to the 5.1 M1 (2023.0.0) milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
5.1 M1 (2023.0.0)
Development

Successfully merging a pull request may close this issue.

Overload multiSearch method to support list of IndexCoordinates AIRahimi/spring-data-elasticsearch
3 participants
@sothawo @spring-projects-issues @AIRahimi