Skip to content

Improve NativeSearchQueryBuilder by adding convenience methods and modifying existing ones. #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Jul 1, 2021

Closes #1854

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@xhaggi xhaggi requested a review from sothawo July 1, 2021 08:06
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 1, 2021
@xhaggi xhaggi force-pushed the 1854-improve-native-search-query-builder branch 3 times, most recently from 42da49a to bb31d02 Compare July 1, 2021 08:13
@xhaggi
Copy link
Contributor Author

xhaggi commented Jul 1, 2021

The most important change is the addition of a convenience method to add multiple SortBuilders at once. But I then decided, while I was at it, to unify the other methods as well.

@xhaggi xhaggi force-pushed the 1854-improve-native-search-query-builder branch from bb31d02 to 1497685 Compare July 2, 2021 11:03
@xhaggi xhaggi force-pushed the 1854-improve-native-search-query-builder branch from 1497685 to 4b06c94 Compare July 2, 2021 11:04
@xhaggi xhaggi requested a review from sothawo July 2, 2021 11:05
@sothawo sothawo merged commit 4ce1137 into spring-projects:main Jul 2, 2021
@xhaggi xhaggi deleted the 1854-improve-native-search-query-builder branch July 6, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NativeSearchQueryBuilder by adding convenience methods and modifying existing ones.
3 participants