Skip to content

Improve NativeSearchQueryBuilder by adding convenience methods and modifying existing ones. #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xhaggi opened this issue Jul 1, 2021 · 2 comments · Fixed by #1855
Closed

Improve NativeSearchQueryBuilder by adding convenience methods and modifying existing ones. #1854

xhaggi opened this issue Jul 1, 2021 · 2 comments · Fixed by #1855
Labels
status: waiting-for-triage An issue we've not yet triaged
Milestone
4.3 M1 (2021.1.0)

Comments

@xhaggi
Copy link
Contributor

xhaggi commented Jul 1, 2021

The NativeSearchQueryBuilder is missing some convenience methods and it contains some methods that are not in line with the other withXXX methods.
@sothawo
Copy link
Collaborator

sothawo commented Jul 1, 2021

please note that the whole client-integration will get a major rewrite in the next time, as we need to integrate the new Elasticsearch client, and the existing NativeSearchQueryBuilder will have to be replaced with something new; see #1853

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 1, 2021
@xhaggi xhaggi mentioned this issue Jul 1, 2021
Merged
5 tasks
@xhaggi
Copy link
Contributor Author

xhaggi commented Jul 1, 2021

IMO the changes I made to the NativeSearchQueryBuilder are minor. I have just opened a PR.

sothawo pushed a commit that referenced this issue Jul 2, 2021
@xhaggi
Improve NativeSearchQueryBuilder by adding convenience methods and mo…
4ce1137 
…difying existing ones.

Original Pull Request #1855 
Closes #1854
@sothawo sothawo added this to the 4.3 M1 (2021.1.0) milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
4.3 M1 (2021.1.0)
3 participants
@xhaggi @sothawo @spring-projects-issues