DATACMNS-1615 - Allow fine grained store specific converter registration. #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. CustomConversions now registers all given user defined converters and selects only those converters from the StoreConversions that convert to or from a store supported simple type. By doing so we make sure to only register supported converters which removes warning messages from the log and reduces the number of converters within the ConversionService.
martin-g
reviewed
Nov 25, 2019
| private static final String CONVERTER_FILTER = "converter from %s to %s as %s converter."; | ||
| private static final String ADD_CONVERTER = "Adding %s" + CONVERTER_FILTER; | ||
| private static final String SKIP_CONVERTER = "Skipping " + CONVERTER_FILTER | ||
| + "%s is not a store supported simple type!"; |
There was a problem hiding this comment.
This probably needs a leading empty space character.
There was a problem hiding this comment.
👍 thanks @martin-g !
Add a Supplier variant for constructing new CustomConversions. This allows store implementations to hook into the actual configuration based on user code. Required for messing with store specific simple type registration based on user decisions.
christophstrobl
force-pushed
the
issue/DATACMNS-1615
branch
from
f3b3801 to
0640d05
Compare
mp911de
pushed a commit
that referenced
this pull request
Feb 7, 2020
…ion. CustomConversions now registers all given user defined converters and selects only those converters from the StoreConversions that convert to or from a store supported simple type. By doing so we make sure to only register supported converters which removes warning messages from the log and reduces the number of converters within the ConversionService. Original pull request: #421.
mp911de
added a commit
that referenced
this pull request
Feb 7, 2020
Replace list creation with constant. Replace ConverterConfiguration.skipFor list with Predicate for flexible conditions. Fix typo. Simplify conditionals. Original pull request: #421.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomConversionsnow registers all given user defined converters and selects only those converters from theStoreConversions(potentially containing superfluous default converters from spring-data-commons) that convert to or from a store supported simple type.By doing so we make sure to only register supported converters which removes warning messages from the log and reduces the number of converters within the
ConversionService.