Skip to content

CustomConversions should allow for selective registration of default converters [DATACMNS-1349] #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jul 2, 2018 · 1 comment
Assignees
Labels
status: duplicate A duplicate of another issue

Comments

@spring-projects-issues
Copy link

Mark Paluch opened DATACMNS-1349 and commented

CustomConversions registers default converters (such as Joda-Time, JSR-310, JSR-310 Backport) for all stores. This is behavior is limiting for stores, that come with native support for a type that is currently converted through one of the default converters.

Datastax Cassandra Driver and MongoDB Driver 3.8 come with converters for some JSR-310 types. Leveraging driver support gets Spring Data converters out of the way so drivers are responsible for reading and writing such types.

Ideally, we find an approach that allows selective registration of converters (e.g. CustomConversions accepting a Predicate<ConvertiblePair>)


Issue Links:

  • DATAMONGO-2017 Use driver codec for Instant, LocalTime, LocalDate, and LocalDateTime
    ("is depended on by")

  • DATAMONGO-2012 Upgrade to MongoDB java driver 3.8 and reactive streams 1.9

  • DATAMONGO-2014 Millis precision vs. nano precision of java.time.Instant on Java 10+

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core support labels Dec 30, 2020
@mp911de
Copy link
Member

mp911de commented Mar 21, 2023

This was introduced with #421/#2043

@mp911de mp911de closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
@mp911de mp911de added status: duplicate A duplicate of another issue and removed in: core Issues in core support type: enhancement A general enhancement labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants