Migrate DependencyTests to ArchUnit #2706
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
added a commit
that referenced
this pull request
Oct 21, 2022
The DependencyTests are reimplemented using ArchUnit and enabled. This uncovered some dependency circles which got fixed: AOT related code was abstracted so configuration code doesn't have to know about AOT specific configuration which is injected using spring.factories. AOT configuration for Querydsl was moved to a separate class as part of the querydsl package. The tests currently fail because `aot` causes cycles. Original pull request #2706
schauder
force-pushed
the
issue/dependencies
branch
from
2de1758 to
37b7f48
Compare
|
Will add Javadoc and license headers. |
The DependencyTests are reimplemented using ArchUnit and enabled. This uncovered some dependency circles which got fixed: AOT related code was abstracted so configuration code doesn't have to know about AOT specific configuration which is injected using spring.factories. AOT configuration for Querydsl was moved to a separate class as part of the querydsl package. The tests currently fail because `aot` causes cycles. Original pull request #2706
schauder
force-pushed
the
issue/dependencies
branch
from
37b7f48 to
999a011
Compare
|
Done. |
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the Degraph based implementation with one based on ArchUnit and reenables the test.
The test currently fails since the aot code causes cycles.