Skip to content

Resolve package cycle between repository.config and repository.aot #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Oct 11, 2022 · 0 comments
Closed

Resolve package cycle between repository.config and repository.aot #2708

mp911de opened this issue Oct 11, 2022 · 0 comments
Labels
theme: aot An issue related to Ahead-Of-Time processing type: task A general task
Milestone
3.0 RC2 (2022.0.0)

Comments

@mp911de
Copy link
Member

mp911de commented Oct 11, 2022

Both packages reference each other and we need to resolve this cycle. It requires likely updates to the configuration interfaces and an improved evaluation of the AOT processor class to avoid references in method signatures.

Follow-up to #2707
@mp911de mp911de added type: task A general task theme: aot An issue related to Ahead-Of-Time processing labels Oct 11, 2022
@mp911de mp911de added this to the 3.0 RC2 (2022.0.0) milestone Nov 2, 2022
@mp911de mp911de closed this as completed in 8d42485 Nov 2, 2022
mp911de added a commit that referenced this issue Nov 2, 2022
@mp911de
Polishing.
5b784d0 
Remove duplicate license headers. Avoid fully-qualified type usage where possible.

See #2708
mp911de added a commit that referenced this issue Nov 2, 2022
@mp911de
Move ReactiveWrappers into o.s.d.util package.
6190baa 
ReactiveWrappers is not tied to repositories so it does not need to reside in the repository.util package. This utility is now located in the data.util package for a better module design and to prevent package cycles.

See #2708
mp911de pushed a commit that referenced this issue Nov 2, 2022
@schauder @mp911de
Make dependency tests based on ArchUnit.
c00f7eb 
The DependencyTests are reimplemented using ArchUnit and enabled.
This uncovered some dependency circles which got fixed:

See #2708
Original pull request #2706
mp911de pushed a commit that referenced this issue Nov 2, 2022
@schauder @mp911de
Make dependency tests based on ArchUnit.
d56bbbd 
The DependencyTests are reimplemented using ArchUnit and enabled.

See #2708
Original pull request #2706
@christophstrobl christophstrobl mentioned this issue Nov 2, 2022
Closed
christophstrobl added a commit to spring-projects/spring-data-mongodb that referenced this issue Nov 2, 2022
@christophstrobl
Follow API changes in data-commons
04a8c47 
Update imports of moved AOT processing types and update reactive wrapper coordinates to new location.

Closes: #4224
See: spring-projects/spring-data-commons#2708
@mp911de mp911de mentioned this issue Nov 2, 2022
Closed
christophstrobl added a commit to spring-projects/spring-data-neo4j that referenced this issue Nov 2, 2022
@christophstrobl
Update reactive wrapper coordinates to new location.
025e2eb 
Closes: #2624
See: spring-projects/spring-data-commons#2708
@mp911de mp911de mentioned this issue Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: aot An issue related to Ahead-Of-Time processing type: task A general task
Projects
None yet
Milestone
3.0 RC2 (2022.0.0)
Development

No branches or pull requests
1 participant
@mp911de