Decouple Paging and Sorting repositories from CrudRepository
#2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
requested changes
Feb 2, 2022
src/main/java/org/springframework/data/repository/support/DefaultRepositoryInvokerFactory.java
Show resolved
Hide resolved
src/main/java/org/springframework/data/repository/PagingAndSortingRepository.java
Show resolved
Hide resolved
This way they can be combined with different variants of CrudRepositories. This affects `PagingAndSortingRepository`, `ReactiveSortingRepository`, `CoroutineSortingRepository`, and `RxJavaSortingRepository`. Any repository implementing those interfaces now needs to also implement a suitable CRUD repository, or needs to manually add the methods from a CRUD repository as needed. Closes #2537
schauder
force-pushed
the
issue/2537-split-pagingandsortingrep
branch
from
628e3e0 to
28ea8f2
Compare
mp911de
requested changes
Feb 10, 2022
src/main/java/org/springframework/data/repository/PagingAndSortingRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/repository/reactive/ReactiveSortingRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/data/repository/reactive/RxJava3SortingRepository.java
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/springframework/data/repository/kotlin/CoroutineSortingRepository.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/springframework/data/repository/kotlin/CoroutineSortingRepository.kt
Outdated
Show resolved
Hide resolved
|
I made all the changes and updated the documentation. |
|
Thanks. I'll handle the merge tomorrow and follow up with modules that require changes. |
|
Thanks. Let me know so we can handle the follow up changes together. |
mp911de
changed the title
CrudRepository
mp911de
pushed a commit
that referenced
this pull request
Feb 11, 2022
This way they can be combined with different variants of CrudRepositories. This affects `PagingAndSortingRepository`, `ReactiveSortingRepository`, `CoroutineSortingRepository`, and `RxJavaSortingRepository`. Any repository implementing those interfaces now needs to also implement a suitable CRUD repository, or needs to manually add the methods from a CRUD repository as needed. Closes #2537 Original pull request: #2540.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2537