Skip to content

Decouple PagingAndSortingRepository from CrudRepository and make it a fragment interface #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schauder opened this issue Jan 24, 2022 · 1 comment
Closed

Decouple PagingAndSortingRepository from CrudRepository and make it a fragment interface #2537

schauder opened this issue Jan 24, 2022 · 1 comment
Assignees
@schauder
Labels
type: enhancement A general enhancement
Milestone
3.0 M2 (2022.0.0)

Comments

@schauder
Copy link
Contributor

See #2535
@schauder schauder added this to the 3.0 M2 (2022.0.0) milestone Jan 24, 2022
@schauder schauder self-assigned this Jan 24, 2022
@schauder schauder added the type: enhancement A general enhancement label Jan 24, 2022
@mp911de
Copy link
Member

mp911de commented Jan 25, 2022

Also, CoroutineSortingRepository, ReactiveSortingRepository, and RxJava variants.

@schauder schauder mentioned this issue Jan 28, 2022
Closed
schauder added a commit that referenced this issue Feb 9, 2022
@schauder
Make sorting repositories independend of CrudRepositories.
28ea8f2 
This way they can be combined with different variants of CrudRepositories.

This affects
`PagingAndSortingRepository`, `ReactiveSortingRepository`, `CoroutineSortingRepository`, and `RxJavaSortingRepository`.

Any repository implementing those interfaces now needs to also implement a suitable CRUD repository, or needs to manually add the methods from a CRUD repository as needed.

Closes #2537
schauder added a commit that referenced this issue Feb 10, 2022
@schauder
Applied changes from code review.
5117e09 
See #2537
Original pull request #2540
schauder added a commit that referenced this issue Feb 10, 2022
@schauder
Added documentation.
8da40c1 
See #2537
Original pull request #2540
@schauder schauder linked a pull request Feb 11, 2022 that will close this issue
Decouple Paging and Sorting repositories from CrudRepository #2540
Closed
@mp911de mp911de changed the title Split PagingAndSortingRepository and make it a fragment interface Decouple PagingAndSortingRepository from CrudRepository and make it a fragment interface Feb 11, 2022
mp911de pushed a commit that referenced this issue Feb 11, 2022
@schauder @mp911de
Decouple Paging and Sorting repositories from CrudRepository.
37eee0e 
This way they can be combined with different variants of CrudRepositories.

This affects
`PagingAndSortingRepository`, `ReactiveSortingRepository`, `CoroutineSortingRepository`, and `RxJavaSortingRepository`.

Any repository implementing those interfaces now needs to also implement a suitable CRUD repository, or needs to manually add the methods from a CRUD repository as needed.

Closes #2537
Original pull request: #2540.
@mp911de mp911de closed this as completed Feb 11, 2022
This was referenced Feb 11, 2022
Closed
Closed
Closed
This was referenced Feb 11, 2022
Closed
Closed
schauder added a commit to spring-projects/spring-data-jpa that referenced this issue Feb 11, 2022
@schauder
Follow through with the split of CRUD repository and sorting repository.
77a0f4d 
Closes #2436
See spring-projects/spring-data-commons#2537
schauder added a commit to spring-projects/spring-data-jpa that referenced this issue Feb 11, 2022
@schauder
Follow through with the split of CRUD repository and sorting repository.
0b94f0d 
Closes #2436
See spring-projects/spring-data-commons#2537
@schauder schauder mentioned this issue Feb 11, 2022
Closed
schauder added a commit to spring-projects/spring-data-r2dbc that referenced this issue Feb 11, 2022
@schauder
Follow through with the split of CRUD repository and sorting repository.
a17e4bb 
Closes #719
See spring-projects/spring-data-commons#2537
@schauder schauder mentioned this issue Feb 11, 2022
Closed
schauder added a commit to spring-projects/spring-data-geode that referenced this issue Feb 11, 2022
@schauder
Follow through with the split of CRUD repository and sorting repository.
f13a542 
Closes #570
See spring-projects/spring-data-commons#2537
@mp911de mp911de mentioned this issue Feb 14, 2022
Closed
@meistermeier meistermeier mentioned this issue Feb 15, 2022
Closed
schauder added a commit that referenced this issue Mar 2, 2022
@schauder
Extend the documentation about how to declare repositories.
b09a0c5 
The new version goes into more details of the various options and is heavily based on changes made for version 3.0.x

Closes #2536
See #2537
@schauder schauder mentioned this issue Mar 2, 2022
Closed
fmbenhassine added a commit to spring-projects/spring-batch that referenced this issue Mar 16, 2022
@fmbenhassine
Fix RepositoryFunctionalTests
9cbde4e 
Due to the decoupling of `PagingAndSortingRepository` from
`CrudRepository` in Spring Data 3 [1], this test has to be updated
to use different repositories between the reader and the writer
according to the expected types for the `repository` property.

[1]: spring-projects/spring-data-commons#2537
lcmarvin pushed a commit to lcmarvin/spring-batch that referenced this issue Apr 16, 2022
@fmbenhassine @lcmarvin
Fix RepositoryFunctionalTests
b7e7f91 
Due to the decoupling of `PagingAndSortingRepository` from
`CrudRepository` in Spring Data 3 [1], this test has to be updated
to use different repositories between the reader and the writer
according to the expected types for the `repository` property.

[1]: spring-projects/spring-data-commons#2537
rayrobert398 added a commit to rayrobert398/spring-data-Mobile-App-Developer-Java that referenced this issue Oct 3, 2022
@rayrobert398
Follow through with the split of CRUD repository and sorting repository.
1c1a9ec 
Closes #719
See spring-projects/spring-data-commons#2537
schauder added a commit that referenced this issue Feb 27, 2023
@schauder
Extend the documentation about how to declare repositories.
1b05fd9 
The new version goes into more details of the various options and is heavily based on changes made for version 3.0.x

Closes #2536
See #2537
@banterCZ banterCZ mentioned this issue Apr 5, 2023
Merged
trayanus1026 pushed a commit to trayanus1026/spring-data-jpa-java that referenced this issue Aug 5, 2023
Follow through with the split of CRUD repository and sorting repository.
eaa8886 
Closes #2436
See spring-projects/spring-data-commons#2537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 M2 (2022.0.0)
Development

Successfully merging a pull request may close this issue.

Decouple Paging and Sorting repositories from CrudRepository spring-projects/spring-data-commons
2 participants
@schauder @mp911de