-
Notifications
You must be signed in to change notification settings - Fork 682
Fixes for #2408 and #2409. #2410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* @since 2.6 | ||
*/ | ||
Iterable<? extends TypeInformation<?>> getPersistentEntityTypeInformation(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation is a bit confusing as it states the method to return null
for a method thats return type is an Iterable
. Wouldn't empty be a better fit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Indeed, the Javadoc still stems from the times that the original method which the comment was copied from returned a single type, not a collection.
…nd Class on PersistentProperty. We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value. Fixes #2408.
…et type if available. This causes us to inspect the most concrete type we can find from a property declaration that might be overridden using an annotation. Fixes #2409.
1a2b42f
to
2fb449c
Compare
…nd Class on PersistentProperty. We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value. Closes: #2408 Original Pull Request: #2410
Update documentation to match method signature. Original Pull Request: #2410
See the commit messages for details. Needs spring-projects/spring-data-jpa#2255 and spring-projects/spring-data-mongodb#3701 merged, too.