Skip to content

Consolidate access to TypeInformation<?> VS. Class<?> on PersistentProperty #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Jul 9, 2021 · 0 comments
Closed

Consolidate access to TypeInformation<?> VS. Class<?> on PersistentProperty #2408

odrotbohm opened this issue Jul 9, 2021 · 0 comments
Assignees
@odrotbohm
Labels
in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement
Milestone
2.6 M1 (2021.1.0)

Comments

@odrotbohm
Copy link
Member

Currently, we have a few inconsistencies in naming methods that return Class<?> VS. TypeInformation<?>. We should name the ones returning the latter …TypeInformation() consistently.
@odrotbohm odrotbohm added in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement labels Jul 9, 2021
@odrotbohm odrotbohm added this to the 2.6 M1 (2021.1.0) milestone Jul 9, 2021
@odrotbohm odrotbohm self-assigned this Jul 9, 2021
This was referenced Jul 9, 2021
Closed
Closed
odrotbohm added a commit that referenced this issue Jul 9, 2021
@odrotbohm
Consolidate names of methods that provide access to TypeInformation a…
d2e2e0a 
…nd Class on PersistentProperty.

We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value.

Fixes #2408.
@odrotbohm odrotbohm linked a pull request Jul 9, 2021 that will close this issue
Fixes for #2408 and #2409. #2410
Closed
christophstrobl pushed a commit to spring-projects/spring-data-mongodb that referenced this issue Jul 12, 2021
@odrotbohm @christophstrobl
Adapt to API consolidation in Spring Data Commons' PersistentProperty.
7d0b070 
Closes: #3700
Original Pull Request: #3701
Related to: spring-projects/spring-data-commons#2408
christophstrobl pushed a commit to spring-projects/spring-data-jpa that referenced this issue Jul 12, 2021
@odrotbohm @christophstrobl
Adapt to API consolidation in Spring Data Commons' PersistentProperty.
400aa0e 
Closes: #2254
Original Pull Request: #2255
Related to: spring-projects/spring-data-commons#2408
christophstrobl pushed a commit that referenced this issue Jul 12, 2021
@odrotbohm @christophstrobl
Consolidate names of methods that provide access to TypeInformation a…
572bea0 
…nd Class on PersistentProperty.

We now name methods returning a TypeInformation<?> …TypeInformation() and ones that return Class<?> …Type(). In case of both flavors provided, overloads should move to the TypeInformation-based variant as the other one simply resolves ….getType() on the returned value.

Fixes #2408.
trayanus1026 pushed a commit to trayanus1026/spring-data-jpa-java that referenced this issue Aug 5, 2023
Adapt to API consolidation in Spring Data Commons' PersistentProperty.
1986d83 
Closes: #2254
Original Pull Request: #2255
Related to: spring-projects/spring-data-commons#2408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: mapping Mapping and conversion infrastructure type: enhancement A general enhancement
Projects
None yet
Milestone
2.6 M1 (2021.1.0)
Development

Successfully merging a pull request may close this issue.

Fixes for #2408 and #2409. spring-projects/spring-data-commons
1 participant
@odrotbohm