DATACMNS-1079 Make ClassGeneratingPropertyAccessorFactory Java 9 aware #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are. ClassGenerationPropertyAccessFactory does not work with Java 9 (without --permit-illegal-access), because making ClassLoader.defineClass accessible fails. Therefore this change moves call to setAccessible to the check that ensures availability of the method.
Refactored all the checks done to check if ClassGeneratingProperty works into separate methods, so the body of isSupported becomes nice and readable.
schauder
force-pushed
the
issue/DATACMNS-1079
branch
from
4a5f287 to
bead289
Compare
mp911de
pushed a commit
that referenced
this pull request
Jun 2, 2017
…s encapsulated. ClassGeneratingPropertyAccessorFactory does not work with Java 9 (encapsulated modules, without --permit-illegal-access), because making ClassLoader.defineClass accessible fails. Therefore this change moves call to setAccessible to the check that ensures availability of the method so isSupported(…) returns false. Original pull request: #224.
mp911de
pushed a commit
that referenced
this pull request
Jun 2, 2017
Refactored all the checks done to check if ClassGeneratingPropertyAccessorFactory works into separate methods, so the body of isSupported becomes nice and readable. Original pull request: #224.
mp911de
added a commit
that referenced
this pull request
Jun 2, 2017
Remove javadoc params without documentation. Reorder methods in the order they are called. Rename arePropertyHashCodesUnique to hasUniquePropertyHashCodes. Add author tag. Formatting. Original pull request: #224.
mp911de
approved these changes
Jun 2, 2017
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.spring.io/browse/DATACMNS-1079