Skip to content

ClassGeneratingPropertyAccessorFactory fails on Java 9 [DATACMNS-1079] #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jun 2, 2017 · 2 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link

Jens Schauder opened DATACMNS-1079 and commented

We need to fall back to the reflection based version. Similar to DATACMNS-1066


Issue Links:

  • DATACMNS-1033 Assert Java 9 compatibility

  • DATACMNS-1080 Inject generated property accessor classes via ReflectUtils.defineClass(…)

Referenced from: pull request #224

@spring-projects-issues
Copy link
Author

Mark Paluch commented

How about exploring possibilities to keep generated property accessors working? Falling back to reflection makes generated accessors generally unusable on Java 9 and later

@spring-projects-issues
Copy link
Author

Jens Schauder commented

Went with your suggestion to include it in the already existing check.

Don't like the control flow by exception to much, but I guess it is really what we want to have in place: If it works do it if it doesn't don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants