DATACMNS-822 - Provide customizers for default pageable and sort resolvers. #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced optional dependencies with Optional and explicit null checks with calls to ifPresent. Used Lambda style instead of anonymous classes where applicable. Converted Hamcrest matchers to AssertJ Minor improvements to formatting.
5 tasks
| * | ||
| * @author Vedran Pavic | ||
| */ | ||
| public interface PageableHandlerMethodArgumentResolverCustomizer { |
There was a problem hiding this comment.
since this is going to be a feature for the Kay release we could add @FunctionalInterface here. Not sure if extending Consumer<PageableHandlerMethodArgumentResolver> and removing customize makes sense here.
Also I'd prefer a naming like PageableHandlerMethodArgumentResolverConfigurationAdapter over ...*Customizer.
| @@ -54,8 +57,13 @@ | |||
| private final ApplicationContext context; | |||
| private final ObjectFactory<ConversionService> conversionService; | |||
|
|
|||
| public SpringDataWebConfiguration(ApplicationContext context, | |||
| @Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) { | |||
| @Autowired private Optional<PageableHandlerMethodArgumentResolverCustomizer> pageableResolverCustomizer; | |||
There was a problem hiding this comment.
can we do without the field injection here?
odrotbohm
pushed a commit
that referenced
this pull request
May 12, 2017
…lvers. Introduced dedicated callback interfaces to customize the HandlerMethodArgumentResolver instances registered by SpringDataWebConfiguration. This allows bean definition registration of those customizer interfaces instead of having to extend a configuration class. Original pull request: #208.
odrotbohm
pushed a commit
that referenced
this pull request
May 12, 2017
Replaced optional dependencies with Optional and explicit null checks with calls to ifPresent. Used Lambda style instead of anonymous classes where applicable. Converted Hamcrest matchers to AssertJ. Minor improvements to formatting. Original pull request: #208.
odrotbohm
added a commit
that referenced
this pull request
May 12, 2017
Switched to implement WebMvcConfigurer over extending WebMvcConfigurerAdapter. Formatting, assertions, Javadoc. Original pull request: #208.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for DATACMNS-822. Also, see spring-projects/spring-boot#7775.
This replaces #192. Rebased it on the new master and changed Hamcrest to AssertJ