Provide a simple way to customize configuration of default pageable and sort resolvers [DATACMNS-822]

[spring-projects-issues]

Vedran Pavic opened DATACMNS-822 and commented

Currently there is no way (AFAIK) to customize the properties of default pageable and sort resolvers provided by SpringDataWebConfiguration and its subclasses. Users have to register their own resolver instance and take care of everything SpringDataWebConfiguration does by default which is quite tedious.

This could be done using callback interfaces which the users can implement and register as Beans that customize the default configuration of the PageableHandlerMethodArgumentResolver and SortHandlerMethodArgumentResolver.

I've got the change implemented using the described approach in my fork:
https://github.com/vpavic/spring-data-commons/tree/DATACMNS-822

If you find this change useful I'll submit the PR

---

Issue Links:

• DATACMNS-1016 EnableSpringDataWebSupport does not let you customise the PageableHandlerMethodArgumentResolver
  ("is duplicated by")

Referenced from: pull request #208

[spring-projects-issues]

Oliver Drotbohm commented

Wouldn't you just subclass SpringDataWebConfiguration and override the methods returning the resolvers to customize the bean definitions the superclass provides, potentially replacing them completely?

[spring-projects-issues]

Vedran Pavic commented

Thanks for your response.

Yes, of course, that's an option. However, I'd like to keep @EnableSpringDataWebSupport (and its internal logic in SpringDataWebConfigurationImportSelector) and reuse the same customizer regardless of the presence of HATEOAS. This would be a Boot-like approach to configuration

[spring-projects-issues]

Vedran Pavic commented

Any chance this gets considered?

IMO there's definitely some value in having the ability to provide simple beans that customize the PageableHandlerMethodArgumentResolver and SortHandlerMethodArgumentResolver in a manner that's completely agnostic to the presence of HATEOAS and can be reused across different projects, vs subclassing SpringDataWebConfiguration or HateoasAwareSpringDataWebConfiguration which depends on whether HATEOAS is used or not.

Thanks

[spring-projects-issues]

Jens Schauder commented

Polished, added documentation and moved to 2.0.x here: https://github.com/spring-projects/spring-data-commons/tree/issue/DATACMNS-822

[spring-projects-issues]

Jens Schauder commented

Can you please take a quick look, at this one? I did the necessary rebasing on the new master and migration to AssertJ, added documentation and think it is good to go, but I'd like a second pair of eyes on it