Skip to content

Support bind markers for IN queries #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

samueldlightfoot
Copy link
Contributor

@samueldlightfoot samueldlightfoot commented Oct 12, 2021

See #1172

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 12, 2021
@mp911de
Copy link
Member

mp911de commented Oct 13, 2021

Thanks a lot. I'm surprised to learn how little code changes are required to make this work. However, one aspect remains as the TermFactory can potentially run all values through CodecRegistry and it would make sense to skip this step if not required. I appreciate the change and I'm currently polishing up your pull request to ensure we can TermFactory only once.

@mp911de mp911de changed the title Support bound variables for IN queries Support bound variables for IN queries Oct 13, 2021
@mp911de mp911de added this to the 3.1.14 (2020.0.14) milestone Oct 13, 2021
@mp911de mp911de linked an issue Oct 13, 2021 that may be closed by this pull request
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 13, 2021
@mp911de mp911de changed the title Support bound variables for IN queries Support bind markers for IN queries Oct 13, 2021
mp911de pushed a commit that referenced this pull request Oct 13, 2021
mp911de added a commit that referenced this pull request Oct 13, 2021
Introduce TermFactory.canBindCollection() to avoid unecessary parameter encoding.

See #1172
Original pull request: #1178.
mp911de pushed a commit that referenced this pull request Oct 13, 2021
mp911de added a commit that referenced this pull request Oct 13, 2021
Introduce TermFactory.canBindCollection() to avoid unecessary parameter encoding.

See #1172
Original pull request: #1178.
mp911de pushed a commit that referenced this pull request Oct 13, 2021
mp911de added a commit that referenced this pull request Oct 13, 2021
Introduce TermFactory.canBindCollection() to avoid unecessary parameter encoding.

See #1172
Original pull request: #1178.
@mp911de
Copy link
Member

mp911de commented Oct 13, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 13, 2021
@samueldlightfoot
Copy link
Contributor Author

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepared IN queries should support bind markers
3 participants