Prepared IN queries should support bind markers

[samueldlightfoot]

Statements generated for IN queries do not use the bindMarker(?) for the collection of values provided for the IN clause. When using prepared statements this means we are creating a prepared statement for each IN query with different parameters. This soon bloats the prepared statement cache when you are selecting by different parameters.

This parameterization is supported in Cassandra:
https://issues.apache.org/jira/browse/CASSANDRA-4210

Expected:
SELECT * FROM Users WHERE id IN ?

Actual:
SELECT * FROM Users WHERE id IN ('id1', 'id2')

Looking in statement factory IN queries that take a collection are handled differently:

		'case IN:

			if (predicate.getValue() instanceof List
					|| (predicate.getValue() != null && predicate.getValue().getClass().isArray())) {
				**return column.in(toLiterals(predicate.getValue()));**
			}

			return column.in(factory.create(predicate.getValue()));`

Example test: 537f96b

I'm happy to have a go at fixing this if we are in agreement it is a bug.

[mp911de]

Thanks a lot. I wasn't aware that Cassandra is able to consume collections/arrays within a single placeholder. The issue we have is a bit that the statement factory isn't aware that the statement is going to be used as a prepared statement. Maybe we we can generally provide collections as a single parameter but then the question remains how this would work with inline parameter rendering.

[samueldlightfoot]

Thanks for the response. Sounds fairly involved and I don't have much familiarity with the codebase. I would really like to fix this but I think it's best I leave it to the professionals :-)

Update: Ideas making use of the BindMarker accepting InRelationBuilder::in.

https://github.com/samueldlightfoot/spring-data-cassandra/tree/1172-in-query-bindmarkers

[samueldlightfoot]

Hi Mark, any thoughts on this?

Happy to help out if you have any ideas.

[mp911de]

Feel free to submit a pull request. I hadn't had the bandwidth yet to wrap my head around it.