Change the maven plugin to allow use a source with classifier.

[bjornlindstrom]

Changed the maven plugin so if a classifier is specified it will look for a source with that classifier and use it if it exists. If not found it will use the main artifact as before. #7659

[snicoll]

@bjornlindstrom can you please expand a bit the use case behind that change? Why are you trying to repackage a different artifact than the the one produced by the regular lifecycle?

[bjornlindstrom]

@snicoll Maybe I misunderstood #7659 but I thought the solution was to repackage the classifier jar produced by the maven-jar plugin.

[snicoll]

Oh my, sorry! I missed the reference to the existing issue.

[ggsenger]

@snicoll is there any further feedback you need? (the waiting-for-feedback label is still present)

we would love to see this pull request merged as we have a similar issue as described in #7659

[snicoll]

Sorry that felt through the crack, thanks for reminding me

[snicoll]

I've done a smoke test with the state of this branch and it didn't work.

I used the following config from a project generated from start.spring.io

<build>
	<plugins>
		<plugin>
			<groupId>org.apache.maven.plugins</groupId>
			<artifactId>maven-jar-plugin</artifactId>
			<configuration>
				<classifier>foo</classifier>
			</configuration>
		</plugin>
		<plugin>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-maven-plugin</artifactId>
			<configuration>
				<classifier>foo</classifier>
			</configuration>
		</plugin>
	</plugins>
</build>

Also, I don't think the semantic of the classifier in this issue is clear. I think the idea I had in mind was to use the main jar but if it did not exist fallback to the classified artifact, if any.

I am not sure it actually addresses the original request so perhaps this solution is a dead-end.

[bjornlindstrom]

Closing it since it seems to be wrong and I don't have the time to sort it out.