Change the maven plugin to allow use a source with classifier #11061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: spring-boot-tools/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/RepackageMojo.java
|
@axtavt Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@axtavt Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
priority: normal
type: enhancement
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
May 15, 2018
Previously, the "classifier" attribute was only used to determine the target classifier of the repackaged archive, always using the main artifact as the source. This commit changes the semantic of the attribute so that an existing archive matching the "classifier" attribute can be used as source, replacing the archive the same way the goal replaces the main archive if no classifier is found. If no artifact with the specified classifier exists, the repackaged archive is still processed based on the main archive and attached to the lifecycle using the value of the classifier attribute. See gh-11061
snicoll
added a commit
that referenced
this pull request
May 15, 2018
* pr/11061: Polish "Allow repackage maven goal to take a source classifier" Allow repackage maven goal to take a source classifier
|
@axtavt thank you so much for your first contribution to Spring Boot. This is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7659.
When classifier is specified, uses attached artifact with the same classifier as source, if present. Otherwise uses main artifact.
Fixed version of rejected pull request #9987.