Skip to content

Add property to enable SPDY or HTTP2 in Undertow #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

See gh-3350

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2015
@philwebb
Copy link
Member

See #3350

@wilkinsona
Copy link
Member

I don't like the server.undertow.option property that was proposed in #3350 and implemented here for a couple of reasons:

  1. There are a lot of options that could be set, so only supporting SPDY or HTTP2 feels rather strange. Also, some options have configurable values that couldn't be set using this approach.
  2. HTTP2 (and SPDY) isn't something that's Undertow-specific. Jetty 9.3 (9.2 is the default at the moment but we do support 9.3 and have a sample for it) also supports HTTP2 and Tomcat will in 9.0.

I think it's worth taking a step back and considering the broader picture for HTTP2 rather than focussing specifically on Undertow and the details of how it's enabled when using Undertow.

@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Feb 29, 2016
@cbelleza
Copy link

cbelleza commented Mar 1, 2016

Nowadays SPDY/HTTP2 is a mandatory resource to get applications safer and faster, having an option by properties is much easier than having a custom EmbeddedFactory to enable it.

For a long while I have been missing this option in Spring Boot and I agree with @wilkinsona this should not only be able for Undertow as another web servers.

Opening a property to set any value to web server I agree is dangerous, but an enum to manage SPDY or HTTP2 is a good option.

What I meant here is that Spring Boot should go further that only allowing to code it.

@wilkinsona
Copy link
Member

I'm going to close this one is the approach that's been implemented isn't the one that we want to take for enabling HTTP2.

@wilkinsona wilkinsona closed this May 10, 2016
@wilkinsona wilkinsona removed status: on-hold We can't start working on this issue yet status: waiting-for-triage An issue we've not yet triaged labels May 10, 2016
@herau
Copy link
Contributor

herau commented Mar 28, 2017

@wilkinsona any news about this topic ? Did you have a common way to enable HTTP2 ?

@wilkinsona
Copy link
Member

No news at the moment. #3350 is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants