Skip to content

Property to enable SPDY / HTTP2.0 in Undertow server #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbelleza opened this issue Jun 29, 2015 · 8 comments
Closed

Property to enable SPDY / HTTP2.0 in Undertow server #3350

cbelleza opened this issue Jun 29, 2015 · 8 comments
Labels
type: enhancement A general enhancement

Comments

@cbelleza
Copy link

Hi,

It would be nice to have a property to enable SPDY / HTTP2.0 for Undertow server in application.properties.

I mean something like:

server.undertow.options=ENABLE_SPDY    # (ENABLE_HTTP2 or ENABLE_SPDY)

That would reflect into embedded web server the following code:

    @Bean
    public UndertowEmbeddedServletContainerFactory embeddedServletContainerFactory() {
        final UndertowEmbeddedServletContainerFactory undertowEmbeddedServletContainerFactory = new UndertowEmbeddedServletContainerFactory();
        undertowEmbeddedServletContainerFactory.addBuilderCustomizers(new UndertowBuilderCustomizer() {
            @Override
            public void customize(final Builder builder) {
                builder.setServerOption(UndertowOptions.ENABLE_SPDY, true);
            }
        });

        return undertowEmbeddedServletContainerFactory;
    }

Keeping in mind I should also add to java execution the ALPN library by all means:
-Xbootclasspath/p:C:\bin\alpn-boot-8.1.3.v20150130.jar

@philwebb philwebb added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with labels Jun 29, 2015
eddumelendez added a commit to eddumelendez/spring-boot that referenced this issue Sep 5, 2015
@cbelleza
Copy link
Author

Is there any idea when this enhancement will be available on Spring Boot?

@philwebb
Copy link
Member

@ofbizbrazil Nobody is currently working on it. It looks like @eddumelendez might have tried something but I don't think I've seen a PR. You're welcome to contribute yourself if you have time.

@cbelleza
Copy link
Author

I took a look at the the codes of @eddumelendez has written on github, and they look what I really meant for.

His task is waiting for a commit into final release, see status: eddumelendez wants to merge 1 commit into spring-projects:master
https://github.com/spring-projects/spring-boot/pull/3904/files

Could you please confirm or may know when it will be committed to master release?

Tks,

@philwebb
Copy link
Member

@ofbizbrazil Ahh, thanks. I'd missed the pull-request. It's not been assigned a target milestone yet so there's no immediate ETA.

@cbelleza
Copy link
Author

Awesome to hear it!

I look forward to having this option on Spring Boot, it will increase the performance of https protocol without doubts.

If you could give a special atention including this feature into the next release, I'd appreciate a lot.

Tks a lot @philwebb

@philwebb
Copy link
Member

See #3904 (comment)

@jonattanva
Copy link

The http2 is already in tomcat?

@bclozel
Copy link
Member

bclozel commented Sep 29, 2017

duplicates #10043

@bclozel bclozel closed this as completed Sep 29, 2017
@snicoll snicoll removed the status: ideal-for-contribution An issue that a contributor can help us with label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants