Skip to content

Upgrade to micrometer 1.0.0-rc8 #11575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jan 9, 2018 · 8 comments
Closed

Upgrade to micrometer 1.0.0-rc8 #11575

snicoll opened this issue Jan 9, 2018 · 8 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone
2.0.0.RC1

Comments

@snicoll
Copy link
Member

snicoll commented Jan 9, 2018

No description provided.

@snicoll snicoll added this to the 2.0.0.RC1 milestone Jan 9, 2018
@snicoll snicoll self-assigned this Jan 9, 2018
snicoll added a commit to snicoll/spring-boot that referenced this issue Jan 9, 2018
@snicoll
Start building against micrometer 1.0.0-SNAPSHOT
29c8e1c 
See spring-projectsgh-11575
@snicoll
Copy link
Member Author

snicoll commented Jan 9, 2018 •
edited
Loading

I've tried to upgrade to the latest snapshot but three tests are failing:

WebMvcFilterTests#timeMethod and WebMbvFilterTests#badClientRequest are failing because Prometheus is not happy when we add an additional tag to a metric:

java.lang.IllegalArgumentException: Prometheus requires that all meters with the same name have the same set of tag keys. There is already an existing meter containing tag keys [exception, method, status, uri]. The meter you are attempting to register has keys [exception, method, public, status, uri].

	at io.micrometer.prometheus.PrometheusMeterRegistry.lambda$collectorByName$9(PrometheusMeterRegistry.java:356)
	at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1877)
	at io.micrometer.prometheus.PrometheusMeterRegistry.collectorByName(PrometheusMeterRegistry.java:343)
	at io.micrometer.prometheus.PrometheusMeterRegistry.newTimer(PrometheusMeterRegistry.java:158)
	at io.micrometer.core.instrument.MeterRegistry.lambda$timer$2(MeterRegistry.java:153)
	at io.micrometer.core.instrument.MeterRegistry.getOrCreateMeter(MeterRegistry.java:639)

DataDogPropertiesConfigAdapterTests#apiKeyInferUri does not seem to pass the apikey anymore


java.lang.AssertionError: 
Expecting:
 <"https://app.datadoghq.com">
to contain:
 <"?api_key=my-key">

@philwebb
Copy link
Member

philwebb commented Jan 9, 2018

/cc @jkschneider

@snicoll snicoll mentioned this issue Jan 10, 2018
Closed
@jkschneider
Copy link
Contributor

The first issue is described here micrometer-metrics/micrometer#266

jkschneider added a commit to jkschneider/spring-boot that referenced this issue Jan 11, 2018
@jkschneider
Micrometer spring-projects#288, Boot issue spring-projects#11575
ac83110
@jkschneider
Copy link
Contributor

All this and more has been addressed in #11598. This can be closed.

@snicoll
Copy link
Member Author

snicoll commented Jan 11, 2018 •
edited
Loading

@jkschneider this issue is here to track the upgrade to 1.0.0.

@srinivasvsk
Copy link

Just an fyi, i'm having errors with m7 and the latest rc7 of micrometer

micrometer-metrics/micrometer#344

@jkschneider
Copy link
Contributor

Just an fyi, i'm having errors with m7 and the latest rc7 of micrometer

This is addressed in the latest Boot snapshot. Because JmxMeterRegistry's signature changed, you won't be able to use Micrometer 1.0.0-rc.7 with Boot 2 M7.

@srinivasvsk
Copy link

ok sounds good, thanks

@snicoll snicoll removed their assignment Jan 16, 2018
@bclozel bclozel changed the title Upgrade to micrometer 1.0.0 Upgrade to micrometer 1.0.0-rc8 Jan 22, 2018
philwebb pushed a commit that referenced this issue Jan 26, 2018
@jkschneider @philwebb
Upgrade to micrometer 1.0.0-SNAPSHOT
d1de1cd 
Move to the snapshots and rework changed APIs in preparation for
the upcoming rc8 release.

See gh-11575
philwebb added a commit that referenced this issue Jan 26, 2018
@philwebb
Migrate to updated micrometer Tags class
643cda4 
See gh-11575
philwebb added a commit that referenced this issue Jan 30, 2018
@philwebb
Fix enums following upstream micrometer change
5632d04 
See gh-11575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.0.0.RC1
Development

No branches or pull requests
4 participants
@snicoll @philwebb @srinivasvsk @jkschneider