Skip to content

Remove hdrhistogram managed dependency #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Nov 4, 2017 · 6 comments
Closed

Remove hdrhistogram managed dependency #10923

philwebb opened this issue Nov 4, 2017 · 6 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Nov 4, 2017

We needed to add it to stop a dependency convergence with micrometer but we should look into other options.

Dependency convergence error for org.hdrhistogram:HdrHistogram:2.1.10 paths to dependency are:
+-org.springframework.boot:spring-boot-starter-actuator:2.0.0.BUILD-SNAPSHOT
  +-io.micrometer:micrometer-core:1.0.0-rc.3
    +-org.hdrhistogram:HdrHistogram:2.1.10
and
+-org.springframework.boot:spring-boot-starter-actuator:2.0.0.BUILD-SNAPSHOT
  +-io.micrometer:micrometer-core:1.0.0-rc.3
    +-org.latencyutils:LatencyUtils:2.0.3
      +-org.hdrhistogram:HdrHistogram:2.1.8
@philwebb philwebb added this to the 2.0.0.RC1 milestone Nov 4, 2017
@philwebb philwebb modified the milestones: 2.0.0.M7, 2.0.0.RC1 Nov 23, 2017
@snicoll
Copy link
Member

snicoll commented Jan 4, 2018

@philwebb there is still a mistmatch now. Micrometer RC5 brings HdrHistogram 2.1.10 and LatencyUtils brings 2.1.8. I don't really know what options you had in mind.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jan 4, 2018
@snicoll
Copy link
Member

snicoll commented Jan 8, 2018

@jkschneider can you please fix that version inconsistency in micrometer? It looks weird that Spring Boot has to deal with that secondary dependency.

@jkschneider
Copy link
Contributor

I'm not clear what the resolution would be. They simply didn't do a release of LatencyUtils to correspond with HdrHistogram 2.1.10, but they are compatible.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 8, 2018
@philwebb
Copy link
Member Author

philwebb commented Jan 8, 2018

@jkschneider I guess ideally the hdrhistogram:2.1.8 dependency would be excluded from latencyutils (in the generated POM) since 2.1.10 is the only version supported. Is there a Gradle equivalent of the enforcer rule that we use to check this?

@jkschneider
Copy link
Contributor

@philwebb Done (for Micrometer 1.0.0).

Is there a Gradle equivalent of the enforcer rule that we use to check this?

Probably? Or it would be a really trivial resolution strategy to implement. Opened an issue here spring-attic/spring-release-plugin#2.

@snicoll
Copy link
Member

snicoll commented Jan 10, 2018

We need #11575

@snicoll snicoll added status: on-hold We can't start working on this issue yet and removed status: feedback-provided Feedback has been provided labels Jan 10, 2018
@snicoll snicoll self-assigned this Jan 15, 2018
@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants