Polish Spring Batch Infrastructure tests #4175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in scope of #4166 polishes the tests in Spring Batch Infrastructure that have been migrated to JUnit 5 in #4125.
The goal of the PR is to improve the readability of the tests by reducing visual clutter and using more concise test constructs where directly available, i.e.
throws
clauses are removed from test method signaturesAssertions
are changed to static importsassertThrows
andassertDoesNotThrow
are used where previoulsytry
,catch
, andfail
were used in a much more verbose style@MockitoSettings
is used to set strictness of mocking at the class levelSome
final
modifiers have been added to class variables to make clearer whether they are expected to change or not during the tests, respectively.