Migrate Spring Batch Infrastructure to JUnit Jupiter #4125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
pushed a commit
that referenced
this pull request
Jul 27, 2022
fmbenhassine
added a commit
that referenced
this pull request
Jul 27, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #4124. It's quite a high number of touched files but I don't think there is a single change that's in itself interesting. If it helps, I can also split this up e.g. in tests from JUnit 3 and from JUnit 4 or something similar.
JUnit 4 is no longer on the classpath of the module.
Together with #4124 and #4112, it feels like the biggest part of migrating all tests to JUnit 5 is already done. The biggest open part is Spring Batch Core which shouldn't take long either. So far this migration is not on any roadmap but I think it would be nice to do it. With the release of Spring Batch 5, there will also be 5 years of JUnit 5. Perfect moment! 🥳