Skip to content

880 adhere to m2settings securityxml and m2settingsxml #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fabapp2
Copy link
Contributor

@fabapp2 fabapp2 commented Nov 3, 2023

Add support for ~/.m2/settings.xml and ~/.m2/settings-security.xml.

  • Maven SettingsInitializer reads the settings with decrypted credentials and adds them to the ExecutionContext Maven when build files get parsed.
  • PrivateArtifactRepositoryTest tests the behavior e2e.
  • Add Maven-related Autoconfiguration and move some beans there
  • MavenExecutionRequest now has the path to settings.xml
  • Polishing

@fabapp2 fabapp2 marked this pull request as ready for review November 3, 2023 11:11
@fabapp2 fabapp2 force-pushed the 880-adhere-to-m2settings-securityxml-and-m2settingsxml branch 3 times, most recently from 14f2911 to ab90ff9 Compare November 10, 2023 08:44
@fabapp2 fabapp2 added type: enhancement New feature or request in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp labels Nov 10, 2023
@fabapp2 fabapp2 self-assigned this Nov 10, 2023
- Clean up and fix ParserParityTestHelper
- Move MavenSettingsInitializer
- Adopt changes in sbm-core
- Integration test for dependency retrieval from private repo
@fabapp2 fabapp2 force-pushed the 880-adhere-to-m2settings-securityxml-and-m2settingsxml branch from 2f0d89a to 78110cf Compare November 10, 2023 10:34
@fabapp2 fabapp2 merged commit 275b211 into version/revamp Nov 10, 2023
@fabapp2 fabapp2 deleted the 880-adhere-to-m2settings-securityxml-and-m2settingsxml branch November 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant