Skip to content

Adhere to ~/.m2/settings-security.xml and ~/.m2/settings.xml #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #844
fabapp2 opened this issue Aug 25, 2023 · 3 comments
Closed
Tracked by #844

Adhere to ~/.m2/settings-security.xml and ~/.m2/settings.xml #880

fabapp2 opened this issue Aug 25, 2023 · 3 comments
Assignees
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 25, 2023

The new sbm-support-rewrite component should enrich ExecutionContext with information from ~/.m2/settings.xml and use (encrypted) passwords from security-settings.xml for auth.

This was started in branch 771 and the required logic needs to be moved and integrated into sbm-support-rewrite component and put to use in RewriteProjectParser.

The 771 branch contains a test for security-settings.xml. This test should be run with both parsers in sbm-support-rewrite.
RewriteMavenParser uses all code from the rewrite-maven-plugin and should act as reference. The RewriteProjectParser should produce the exact same result and will in the future replace the RewriteMavenParser.

These are the tests for the logic that needs to be moved:

@bsmahi
Copy link
Contributor

bsmahi commented Aug 28, 2023

@fabapp2 as discussed could you please assign this to me?

Thanks,
Mahi

@shresthaujjwal
Copy link

@bsmahi @fabapp2 any update or progress on this ?

@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 11, 2023

Closed by #986

@fabapp2 fabapp2 closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants