Skip to content

Fix #457 - Enhance initialise spring boot integration test #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2022
Merged

Fix #457 - Enhance initialise spring boot integration test #460

merged 2 commits into from
Oct 3, 2022

Conversation

ahmedmq
Copy link
Contributor

@ahmedmq ahmedmq commented Oct 3, 2022

  • Add application.properties to multi-module project setup
  • Fix whitespaces and remove comments in testcode to match textual content with migrated code
  • Fix file path when comparing testcode and migrated code

Mushtaq Ahmed added 2 commits October 3, 2022 14:11
Fix #457 - Enhance initialize spring boot integration test
a92dde8 
- Add `application.properties` to multi-module project setup
- Fix whitespaces and remove comments in testcode to match textual content with migrated code
- Fix file path when comparing testcode and migrated code
Fix #284 - Add version to spring-boot-maven-plugin
5c017d0
@sanagaraj-pivotal
Copy link
Contributor

Thanks for the PR @ahmedmq 🎉🎉🎉🎉

fabapp2
fabapp2 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@fabapp2 fabapp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahmedmq for your contribution 🚀

I realised the addDefaultPropertiesFileToTopModule can be replaced and opened a new issue: #461

@fabapp2 fabapp2 added the type: bug Something isn't working label Oct 3, 2022
@fabapp2 fabapp2 linked an issue Oct 3, 2022 that may be closed by this pull request
The test InitializeSpringBootMigrationRecipeIntegrationTest passes but it actually does not compare the migrated code #457
Closed
@fabapp2 fabapp2 added this to the v0.13.0 milestone Oct 3, 2022
@fabapp2 fabapp2 linked an issue Oct 3, 2022 that may be closed by this pull request
Version for spring-boot-maven-plugin must be set when Boot dependencies are added by #284
Closed
@fabapp2 fabapp2 merged commit 405a05b into spring-projects-experimental:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabapp2 fabapp2 fabapp2 approved these changes

Assignees

@ahmedmq ahmedmq

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.13.0
3 participants
@ahmedmq @sanagaraj-pivotal @fabapp2