-
Notifications
You must be signed in to change notification settings - Fork 90
Version for spring-boot-maven-plugin must be set when Boot dependencies are added by #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hey @fabapp2 - Can i work on this issue? |
Hi @ahmedmq ! That would be awesome 🚀 |
assigned-to: @ahmedmq |
Hey @fabapp2 I noticed that the test |
Hey @fabapp2 - That should be perfectly fine. I have submitted a pull request. Please let me know if you need any changes |
* Fix #457 - Enhance initialize spring boot integration test - Add `application.properties` to multi-module project setup - Fix whitespaces and remove comments in testcode to match textual content with migrated code - Fix file path when comparing testcode and migrated code * Fix #284 - Add version to spring-boot-maven-plugin
Describe the bug
The recipe
initialize-spring-boot-migration
must set the version for thespring-boot-maven-plugin
to the current Spring Boot version.To Reproduce
Run the recipe against a non-Spring application.
spring-boot-maven-plugin
has no version.Expected behavior
The version for
spring-boot-maven-plugin
should be explicitly set to the Spring Boot version used.Additional context
When Spring Boot dependencies are imported using a
dependencyManagement
section instead of parent pom the version of plugins is not managed and must be explicitly setreported-by: @andreasf
The text was updated successfully, but these errors were encountered: